Thread: [pgAdmin][RM6197] Incomplete ERD image downloaded.

[pgAdmin][RM6197] Incomplete ERD image downloaded.

From
Aditya Toshniwal
Date:
Hi Hackers,

Attached patch will improve and fix things except, the links are partially rendered in case of SVG overflow. That needs to be fixed in html2canvas library. Ref - https://github.com/niklasvh/html2canvas/issues/1486. In addition, safari seems to be distorting the link paths.
Considering the majority of users are on Chrome and Firefox, the fix will help most users until issues for Safari are fixed.

Please review.

--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"
Attachment

Re: [pgAdmin][RM6197] Incomplete ERD image downloaded.

From
Akshay Joshi
Date:
Thanks, patch applied.

On Thu, Feb 11, 2021 at 4:16 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached patch will improve and fix things except, the links are partially rendered in case of SVG overflow. That needs to be fixed in html2canvas library. Ref - https://github.com/niklasvh/html2canvas/issues/1486. In addition, safari seems to be distorting the link paths.
Considering the majority of users are on Chrome and Firefox, the fix will help most users until issues for Safari are fixed.

Please review.

--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246