Thread: pgsql: Report the true database name on connection errors

pgsql: Report the true database name on connection errors

From
Alvaro Herrera
Date:
Report the true database name on connection errors

When reporting connection errors, we might show a database name in the
message that's not the one we actually tried to connect to, if the
database was taken from libpq defaults instead of from user parameters.
Fix such error messages to use PQdb(), which reports the correct name.

(But, per commit 2930c05634bc, make sure not to try to print NULL.)

Apply to branches 9.5 through 13.  Branch master has already been
changed differently by commit 58cd8dca3de0.

Reported-by: Robert Haas <robertmhaas@gmail.com>
Discussion: https://postgr.es/m/CA+TgmobssJ6rS22dspWnu-oDxXevGmhMD8VcRBjmj-b9UDqRjw@mail.gmail.com

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/11a708f8159fa9752ecc78a157b62d54cd0b7a2f

Modified Files
--------------
contrib/oid2name/oid2name.c  | 2 +-
contrib/vacuumlo/vacuumlo.c  | 2 +-
src/bin/pg_dump/pg_dumpall.c | 2 +-
src/bin/pgbench/pgbench.c    | 5 +++--
4 files changed, 6 insertions(+), 5 deletions(-)