Thread: fix typo in ReorderBufferProcessTXN
Hi
I found a possible typo in the comment of ReorderBufferProcessTXN().
* relmapper has no "historic" view, in contrast to normal
* the normal catalog during decoding. Thus repeated
Is there an extra ‘normal’ in the comment ?
in contrast to normal the normal catalog during decoding == >> in contrast to the normal catalog during decoding
Best regards,
houzj
Attachment
On Tue, Jan 5, 2021 at 9:54 AM Hou, Zhijie <houzj.fnst@cn.fujitsu.com> wrote: > > Hi > > > > I found a possible typo in the comment of ReorderBufferProcessTXN(). > > > > * relmapper has no "historic" view, in contrast to normal > > * the normal catalog during decoding. Thus repeated > > > > Is there an extra ‘normal’ in the comment ? Yeah, I think so. > in contrast to normal the normal catalog during decoding == >> in contrast to the normal catalog during decoding Looks good change to me. Regards, -- Masahiko Sawada EnterpriseDB: https://www.enterprisedb.com/
On Tue, Jan 5, 2021 at 7:13 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote: > > On Tue, Jan 5, 2021 at 9:54 AM Hou, Zhijie <houzj.fnst@cn.fujitsu.com> wrote: > > > in contrast to normal the normal catalog during decoding == >> in contrast to the normal catalog during decoding > > Looks good change to me. > +1. I will push this in some time. -- With Regards, Amit Kapila.
On Tue, Jan 5, 2021 at 7:45 AM Amit Kapila <amit.kapila16@gmail.com> wrote: > > On Tue, Jan 5, 2021 at 7:13 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote: > > > > On Tue, Jan 5, 2021 at 9:54 AM Hou, Zhijie <houzj.fnst@cn.fujitsu.com> wrote: > > > > > in contrast to normal the normal catalog during decoding == >> in contrast to the normal catalog during decoding > > > > Looks good change to me. > > > > +1. I will push this in some time. > Pushed. -- With Regards, Amit Kapila.