Thread: [PATCH] Implements SPIN_LOCK on ARM

[PATCH] Implements SPIN_LOCK on ARM

From
David CARLIER
Date:
Hi here a little update proposal for ARM architecture.

Kind regards.

Attachment

Re: [PATCH] Implements SPIN_LOCK on ARM

From
Tom Lane
Date:
David CARLIER <devnexen@gmail.com> writes:
> Hi here a little update proposal for ARM architecture.

This sort of thing is not a "little proposal" where you can just
send in an unsupported patch and expect it to be accepted.
You need to provide some evidence that (a) it actually does anything
useful and (b) it isn't a net loss on some ARM architectures.

For comparison's sake, see

https://www.postgresql.org/message-id/flat/CAB10pyamDkTFWU_BVGeEVmkc8%3DEhgCjr6QBk02SCdJtKpHkdFw%40mail.gmail.com

where we still haven't pulled the trigger despite a great deal
more than zero testing.

FWIW, some casual googling suggests that ARM "yield" is not
all that much like x86 "pause": it supposedly encourages
the system to swap control away from the thread altogether,
exactly what we *don't* want in a spinloop.  So I'm a little
doubtful whether there's a case to be made for this at all.
But for sure, you haven't tried to make a case.

            regards, tom lane