Thread: Remove cache_plan argument comments to ri_PlanCheck

On Tue, Nov 24, 2020 at 4:46 PM Li Japin <japinli@hotmail.com> wrote:
>
> Hi, hackers
>
> I found that the cache_plan argument to ri_PlanCheck already been remove since
> 5b7ba75f7ff854003231e8099e3038c7e2eba875.   I think we can remove the comments
> tor cache_plan to ri_PlanCheck.
>
> diff --git a/src/backend/utils/adt/ri_triggers.c b/src/backend/utils/adt/ri_triggers.c
> index 7e2b2e3dd6..02b1a3868f 100644
> --- a/src/backend/utils/adt/ri_triggers.c
> +++ b/src/backend/utils/adt/ri_triggers.c
> @@ -2130,9 +2130,6 @@ InvalidateConstraintCacheCallBack(Datum arg, int cacheid, uint32 hashvalue)
>
>  /*
>   * Prepare execution plan for a query to enforce an RI restriction
> - *
> - * If cache_plan is true, the plan is saved into our plan hashtable
> - * so that we don't need to plan it again.
>   */
>  static SPIPlanPtr
>  ri_PlanCheck(const char *querystr, int nargs, Oid *argtypes,
>

Your patch looks good to me.

-- 
With Regards,
Amit Kapila.

On Tue, Nov 24, 2020 at 7:26 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Tue, Nov 24, 2020 at 4:46 PM Li Japin <japinli@hotmail.com> wrote:
> >
> > Hi, hackers
> >
> > I found that the cache_plan argument to ri_PlanCheck already been remove since
> > 5b7ba75f7ff854003231e8099e3038c7e2eba875.   I think we can remove the comments
> > tor cache_plan to ri_PlanCheck.
> >
> > diff --git a/src/backend/utils/adt/ri_triggers.c b/src/backend/utils/adt/ri_triggers.c
> > index 7e2b2e3dd6..02b1a3868f 100644
> > --- a/src/backend/utils/adt/ri_triggers.c
> > +++ b/src/backend/utils/adt/ri_triggers.c
> > @@ -2130,9 +2130,6 @@ InvalidateConstraintCacheCallBack(Datum arg, int cacheid, uint32 hashvalue)
> >
> >  /*
> >   * Prepare execution plan for a query to enforce an RI restriction
> > - *
> > - * If cache_plan is true, the plan is saved into our plan hashtable
> > - * so that we don't need to plan it again.
> >   */
> >  static SPIPlanPtr
> >  ri_PlanCheck(const char *querystr, int nargs, Oid *argtypes,
> >
>
> Your patch looks good to me.
>

Pushed!

-- 
With Regards,
Amit Kapila.