Thread: Default role -> Predefined role
Greetings, Attached is a patch to move from 'default role' terminology to 'predefined role' in the documentation. In the code, I figured it made more sense to avoid saying either one and instead opted for just 'ROLE_NAME_OF_ROLE' as the #define, which we were very close to (one removing the 'DEFAULT' prefix) but didn't actually entirely follow. This would only apply to HEAD, and we'd use the doc redirect + doc alias features of the website to prevent links to things like /current from breaking and to provide a smooth path. In the back-branches there would be a smaller update that just notes that in v14 'default roles' were renamed to 'predefined roles'. Compiles and passes regressions, and I didn't find any other obvious references to 'default roles'. Where I did find such comments in the code, I opted generally to just remove the 'default' qualification as it wasn't really needed. I had contemplated calling these 'capabilities' or similar but ended up deciding not to- they really are roles, after all. Thoughts? Thanks, Stephen
Attachment
> On 20 Nov 2020, at 22:13, Stephen Frost <sfrost@snowman.net> wrote: > Attached is a patch to move from 'default role' terminology to > 'predefined role' in the documentation. In the code, I figured it made > more sense to avoid saying either one and instead opted for just > 'ROLE_NAME_OF_ROLE' as the #define, which we were very close to (one > removing the 'DEFAULT' prefix) but didn't actually entirely follow. Predefined is a much better terminology than default for these roles, makes the concept a lot clearer. +1 on this patch. > I had contemplated calling these 'capabilities' or similar but ended up > deciding not to- they really are roles, after all. Agreed, roles is better here. cheers ./daniel
Greetings, * Daniel Gustafsson (daniel@yesql.se) wrote: > > On 20 Nov 2020, at 22:13, Stephen Frost <sfrost@snowman.net> wrote: > > Attached is a patch to move from 'default role' terminology to > > 'predefined role' in the documentation. In the code, I figured it made > > more sense to avoid saying either one and instead opted for just > > 'ROLE_NAME_OF_ROLE' as the #define, which we were very close to (one > > removing the 'DEFAULT' prefix) but didn't actually entirely follow. > > Predefined is a much better terminology than default for these roles, makes the > concept a lot clearer. +1 on this patch. Alright, now that 3b0c647bbfc52894d979976f1e6d60e40649bba7 has gone in, we can come back to the topic of renaming default roles to predefined roles as of v14. Attached is a patch which does that and adds a section to the obsolete appendix which should result in the existing links to the default roles page continuing to work (but going to the page explaining that they've been renamed to predefined roles) once v14 is released with the update. Unless there's anything further on this, I'll plan to push in the next day or so. Thanks! Stephen
Attachment
Greetings, * Stephen Frost (sfrost@snowman.net) wrote: > Unless there's anything further on this, I'll plan to push in the next > day or so. ... and done. Thanks! Stephen