Thread: pgsql: Fix parsePGArray() error checking in pg_dump.

Fix parsePGArray() error checking in pg_dump.

Coverity complained about a defect in commit 257836a7:

  Calling "parsePGArray" without checking return value (as is
  done elsewhere 11 out of 13 times).

Fix, and also check for empty strings explicitly (NULL as represented by
PQgetvalue()).  That worked correctly before only because parsePGArray()
happens to set *nitems = 0 when it fails on an empty string.  Also
convert a sanity check assertion to an error to be more paranoid, and
pgindent a nearby line.

Reported-by: Michael Paquier <michael@paquier.xyz>

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3636efa11945af64479995609762b2626c6c319a

Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 28 ++++++++++++++++++++--------
1 file changed, 20 insertions(+), 8 deletions(-)