Thread: hash_array_extended() needs to pass down collation

I noticed that hash_array_extended() does not pass down the collation to 
the element's collation function, unlike hash_array().  As a 
consequence, hash partitioning using text arrays as partition key fails.

The attached patch fixes this.  I propose to backpatch this.

On 02/11/2020 09:40, Peter Eisentraut wrote:
> I noticed that hash_array_extended() does not pass down the collation to
> the element's collation function, unlike hash_array().  As a
> consequence, hash partitioning using text arrays as partition key fails.
> 
> The attached patch fixes this.  I propose to backpatch this.

+1. Straightforward oversight in commit 5e1963fb764e.

- Heikki

Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> I noticed that hash_array_extended() does not pass down the collation to 
> the element's collation function, unlike hash_array().  As a 
> consequence, hash partitioning using text arrays as partition key fails.

> The attached patch fixes this.  I propose to backpatch this.

LGTM

            regards, tom lane

On Mon, Nov 02, 2020 at 10:01:53AM -0500, Tom Lane wrote:
> Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
>> I noticed that hash_array_extended() does not pass down the collation to
>> the element's collation function, unlike hash_array().  As a
>> consequence, hash partitioning using text arrays as partition key fails.
>
>> The attached patch fixes this.  I propose to backpatch this.
>
> LGTM

+1.
--
Michael

On 2020-11-03 11:48, Michael Paquier wrote:
> On Mon, Nov 02, 2020 at 10:01:53AM -0500, Tom Lane wrote:
>> Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
>>> I noticed that hash_array_extended() does not pass down the collation to
>>> the element's collation function, unlike hash_array().  As a
>>> consequence, hash partitioning using text arrays as partition key fails.
>>
>>> The attached patch fixes this.  I propose to backpatch this.
>>
>> LGTM
> 
> +1.

committed