Thread: PostgresNode::backup uses spread checkpoint?

I noticed a few days ago that method backup() in PostgresNode uses
pg_basebackup without specifying a checkpoint mode -- and the default is
a spread checkpoint, which may cause any tests that use that to take
slightly longer than the bare minimum.

I propose to make it use a fast checkpoint, as per the attached.

-- 
Álvaro Herrera

On 10/20/20 11:01 AM, Alvaro Herrera wrote:
> I noticed a few days ago that method backup() in PostgresNode uses
> pg_basebackup without specifying a checkpoint mode -- and the default is
> a spread checkpoint, which may cause any tests that use that to take
> slightly longer than the bare minimum.
> 
> I propose to make it use a fast checkpoint, as per the attached.

+1.

-- 
-David
david@pgmasters.net

On Tue, Oct 20, 2020 at 11:13:34AM -0400, David Steele wrote:
> On 10/20/20 11:01 AM, Alvaro Herrera wrote:
>> I noticed a few days ago that method backup() in PostgresNode uses
>> pg_basebackup without specifying a checkpoint mode -- and the default is
>> a spread checkpoint, which may cause any tests that use that to take
>> slightly longer than the bare minimum.
>>
>> I propose to make it use a fast checkpoint, as per the attached.
>
> +1.

+1.

-   $self->host, '-p', $self->port, '--no-sync');
+   $self->host, '-p', $self->port, '-cfast', '--no-sync');

Some nits: I would recommend to use the long option name, and list
the option name and its value as two separate arguments of the
command.
--
Michael

On Wed, Oct 21, 2020 at 07:55:18AM +0900, Michael Paquier wrote:
> Some nits: I would recommend to use the long option name, and list
> the option name and its value as two separate arguments of the
> command.

For the archives: this got applied as of 831611b.
--
Michael