Thread: Fix typos in reorderbuffer.c
@@ -1432,7 +1432,7 @@ ReorderBufferCleanupTXN(ReorderBuffer *rb, ReorderBufferTXN *txn) ReorderBufferCleanupTXN(rb, subtxn); } - /* cleanup changes in the toplevel txn */ + /* cleanup changes in the txn */ dlist_foreach_modify(iter, &txn->changes) { ReorderBufferChange *change; @@ -1533,7 +1533,7 @@ ReorderBufferTruncateTXN(ReorderBuffer *rb, ReorderBufferTXN *txn) ReorderBufferTruncateTXN(rb, subtxn); } - /* cleanup changes in the toplevel txn */ + /* cleanup changes in the txn */ dlist_foreach_modify(iter, &txn->changes) { ReorderBufferChange *change; Both the above functions are recursive and will clean the changes for both the top-level transaction and subtransactions. So, I feel the comments should be accordingly updated. -- With Regards, Amit Kapila.
Attachment
On Thu, 8 Oct 2020 at 17:37, Amit Kapila <amit.kapila16@gmail.com> wrote: > > @@ -1432,7 +1432,7 @@ ReorderBufferCleanupTXN(ReorderBuffer *rb, > ReorderBufferTXN *txn) > ReorderBufferCleanupTXN(rb, subtxn); > } > > - /* cleanup changes in the toplevel txn */ > + /* cleanup changes in the txn */ > dlist_foreach_modify(iter, &txn->changes) > { > ReorderBufferChange *change; > @@ -1533,7 +1533,7 @@ ReorderBufferTruncateTXN(ReorderBuffer *rb, > ReorderBufferTXN *txn) > ReorderBufferTruncateTXN(rb, subtxn); > } > > - /* cleanup changes in the toplevel txn */ > + /* cleanup changes in the txn */ > dlist_foreach_modify(iter, &txn->changes) > { > ReorderBufferChange *change; > > Both the above functions are recursive and will clean the changes for > both the top-level transaction and subtransactions. Right. > So, I feel the > comments should be accordingly updated. +1 for this change. Regards, -- Masahiko Sawada http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On Thu, Oct 8, 2020 at 2:40 PM Masahiko Sawada <masahiko.sawada@2ndquadrant.com> wrote: > > On Thu, 8 Oct 2020 at 17:37, Amit Kapila <amit.kapila16@gmail.com> wrote: > > > > > So, I feel the > > comments should be accordingly updated. > > +1 for this change. > Thanks, I have pushed this and along with it pushed a typo-fix in logical.c. -- With Regards, Amit Kapila.