Thread: NOTIFY docs fixup - emit and deliver consistency
Hackers,
Over in [1] Greg got confused by some wording in our NOTIFY documentation. The attached patch uses "emits" and "delivered" more consistently (in lieu of "processed" in the complained of location).
David J.
Attachment
"David G. Johnston" <david.g.johnston@gmail.com> writes:
> Over in [1] Greg got confused by some wording in our NOTIFY documentation.
> The attached patch uses "emits" and "delivered" more consistently (in
> lieu of "processed" in the complained of location).
Meh --- I do not think "emitted" is much of an improvement over "sent".
(I agree it's not great that these two places don't use matching
terminology, though.) Neither is clear as to where the message is
sent or emitted.
As for the other end of it, I don't like "delivered" because it presumes
that the processing action necessarily is to send the message to the
connected client. When a backend takes a message off the queue, it may
just drop it on the floor because its client is not listening to that
channel. Nonetheless, until it's done so that message must consume
queue space.
Maybe we could use terminology along the lines of "added to the
queue" and "removed from the queue"?
regards, tom lane
On Tue, Sep 29, 2020 at 7:58 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
Maybe we could use terminology along the lines of "added to the
queue" and "removed from the queue"?
Quickly looking it over with this in mind there are a few spots that can be cleaned up and linked together by explicitly talking about a FIFO queue as the mechanism instead of the less precise send/process/deliver. A bit more invasive but I think it will be done more clearly with this approach.
David J.
On Tue, Sep 29, 2020 at 8:38 PM David G. Johnston <david.g.johnston@gmail.com> wrote:
On Tue, Sep 29, 2020 at 7:58 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:Maybe we could use terminology along the lines of "added to the
queue" and "removed from the queue"?Quickly looking it over with this in mind there are a few spots that can be cleaned up and linked together by explicitly talking about a FIFO queue as the mechanism instead of the less precise send/process/deliver. A bit more invasive but I think it will be done more clearly with this approach.
As attached.