Fix use-after-free bug with event triggers in an extension script
ALTER TABLE commands in an extension script are added to an event
trigger command list; but starting with commit b5810de3f4 they do so in
a memory context that's too short-lived, so when execution ends and time
comes to use the entries, they've already been freed.
(This would also be a problem with ALTER TABLE commands in a
multi-command query string, but these serendipitously end in
PortalContext -- which probably explains why it took so long for this to
be reported.)
Fix by using the memory context specifically set for that, instead.
Backpatch to 13, where the aforementioned commit appeared.
Reported-by: Philippe Beaudoin
Author: Jehan-Guillaume de Rorthais <jgdr@dalibo.com>
Discussion: https://postgr.es/m/20200902193715.6e0269d4@firost
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/ced138e8cbac7f5a840de8679e9882665478c680
Modified Files
--------------
src/backend/commands/event_trigger.c | 6 ++++++
src/test/modules/test_extensions/Makefile | 6 ++++--
.../modules/test_extensions/expected/test_extensions.out | 5 +++++
src/test/modules/test_extensions/sql/test_extensions.sql | 6 ++++++
.../test_extensions/test_ext_evttrig--1.0--2.0.sql | 7 +++++++
.../modules/test_extensions/test_ext_evttrig--1.0.sql | 16 ++++++++++++++++
.../modules/test_extensions/test_ext_evttrig.control | 3 +++
7 files changed, 47 insertions(+), 2 deletions(-)
