Thread: Use for name of unnamed portal's memory context
I propose the attached little patch to set the name of the memory context of an unnamed portal to "<unnamed>" instead of just an empty string. Otherwise the debug memory context dump looks a little confusing. We use this convention elsewhere for making unnamed statements etc. more clearly visible. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Attachment
so 5. 9. 2020 v 8:14 odesílatel Peter Eisentraut <peter.eisentraut@2ndquadrant.com> napsal:
I propose the attached little patch to set the name of the memory
context of an unnamed portal to "<unnamed>" instead of just an empty
string. Otherwise the debug memory context dump looks a little
confusing. We use this convention elsewhere for making unnamed
statements etc. more clearly visible.
+1
Pavel
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On Sat, Sep 5, 2020 at 8:25 AM Pavel Stehule <pavel.stehule@gmail.com> wrote: > > so 5. 9. 2020 v 8:14 odesílatel Peter Eisentraut <peter.eisentraut@2ndquadrant.com> napsal: >> >> I propose the attached little patch to set the name of the memory >> context of an unnamed portal to "<unnamed>" instead of just an empty >> string. Otherwise the debug memory context dump looks a little >> confusing. We use this convention elsewhere for making unnamed >> statements etc. more clearly visible. > > > +1 +1 too, and obviously patch looks good.
Julien Rouhaud <rjuju123@gmail.com> writes: > +1 too, and obviously patch looks good. The adjacent comment needs updating. regards, tom lane
On 2020-09-05 17:10, Tom Lane wrote: > Julien Rouhaud <rjuju123@gmail.com> writes: >> +1 too, and obviously patch looks good. > > The adjacent comment needs updating. committed with that change -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services