Thread: Fix typo in procarrary.c
Hi, I've attached the patch for $subject. s/replications lots/replication slots/ Regards, -- Masahiko Sawada http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Attachment
On 2020/08/21 10:58, Masahiko Sawada wrote:
> Hi,
>
> I've attached the patch for $subject.
>
> s/replications lots/replication slots/
Thanks for the patch!
Also it's better to s/replications slots/replication slots/ ?
--- a/src/backend/storage/ipc/procarray.c
+++ b/src/backend/storage/ipc/procarray.c
@@ -198,7 +198,7 @@ typedef struct ComputeXidHorizonsResult
* be removed.
*
* This likely should only be needed to determine whether pg_subtrans can
- * be truncated. It currently includes the effects of replications slots,
+ * be truncated. It currently includes the effects of replication slots,
* for historical reasons. But that could likely be changed.
*/
TransactionId oldest_considered_running;
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
On Fri, 21 Aug 2020 at 11:18, Fujii Masao <masao.fujii@oss.nttdata.com> wrote: > > > > On 2020/08/21 10:58, Masahiko Sawada wrote: > > Hi, > > > > I've attached the patch for $subject. > > > > s/replications lots/replication slots/ > > Thanks for the patch! > > Also it's better to s/replications slots/replication slots/ ? > > --- a/src/backend/storage/ipc/procarray.c > +++ b/src/backend/storage/ipc/procarray.c > @@ -198,7 +198,7 @@ typedef struct ComputeXidHorizonsResult > * be removed. > * > * This likely should only be needed to determine whether pg_subtrans can > - * be truncated. It currently includes the effects of replications slots, > + * be truncated. It currently includes the effects of replication slots, > * for historical reasons. But that could likely be changed. > */ > TransactionId oldest_considered_running; > Indeed. I agree with you. Regards, -- Masahiko Sawada http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 2020/08/21 12:29, Masahiko Sawada wrote: > On Fri, 21 Aug 2020 at 11:18, Fujii Masao <masao.fujii@oss.nttdata.com> wrote: >> >> >> >> On 2020/08/21 10:58, Masahiko Sawada wrote: >>> Hi, >>> >>> I've attached the patch for $subject. >>> >>> s/replications lots/replication slots/ >> >> Thanks for the patch! >> >> Also it's better to s/replications slots/replication slots/ ? >> >> --- a/src/backend/storage/ipc/procarray.c >> +++ b/src/backend/storage/ipc/procarray.c >> @@ -198,7 +198,7 @@ typedef struct ComputeXidHorizonsResult >> * be removed. >> * >> * This likely should only be needed to determine whether pg_subtrans can >> - * be truncated. It currently includes the effects of replications slots, >> + * be truncated. It currently includes the effects of replication slots, >> * for historical reasons. But that could likely be changed. >> */ >> TransactionId oldest_considered_running; >> > > Indeed. I agree with you. Thanks! So I pushed both fixes. Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION
On Fri, 21 Aug 2020 at 12:39, Fujii Masao <masao.fujii@oss.nttdata.com> wrote: > > > > On 2020/08/21 12:29, Masahiko Sawada wrote: > > On Fri, 21 Aug 2020 at 11:18, Fujii Masao <masao.fujii@oss.nttdata.com> wrote: > >> > >> > >> > >> On 2020/08/21 10:58, Masahiko Sawada wrote: > >>> Hi, > >>> > >>> I've attached the patch for $subject. > >>> > >>> s/replications lots/replication slots/ > >> > >> Thanks for the patch! > >> > >> Also it's better to s/replications slots/replication slots/ ? > >> > >> --- a/src/backend/storage/ipc/procarray.c > >> +++ b/src/backend/storage/ipc/procarray.c > >> @@ -198,7 +198,7 @@ typedef struct ComputeXidHorizonsResult > >> * be removed. > >> * > >> * This likely should only be needed to determine whether pg_subtrans can > >> - * be truncated. It currently includes the effects of replications slots, > >> + * be truncated. It currently includes the effects of replication slots, > >> * for historical reasons. But that could likely be changed. > >> */ > >> TransactionId oldest_considered_running; > >> > > > > Indeed. I agree with you. > > Thanks! So I pushed both fixes. > Thanks! Regards, -- Masahiko Sawada http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services