Thread: Patch for SonarQube code scan fixes.

Patch for SonarQube code scan fixes.

From
Nikhil Mohite
Date:
Hi Team,

I have fixed some code smell issues in the SonarQube scan, PFA patch.
Details as follows:

1. languages:
  • Refactor this function to reduce its Cognitive Complexity from 33 to the 15 allowed.
2. foreign table:
  • Refactor this function to reduce its Cognitive Complexity from 73 to the 15 allowed.
3. schema_diff_utils:
  • Refactor this function to reduce its Cognitive Complexity from 30 to the 15 allowed.
4. schema utils:
  • Refactor this function to reduce its Cognitive Complexity from 23 to the 15 allowed.
  • Refactor this function to reduce its Cognitive Complexity from 38 to the 15 allowed.
5. schema views:
  • Refactor this function to reduce its Cognitive Complexity from 18 to the 15 allowed.
6. schema diff directory_compare:
  • Refactor this function to reduce its Cognitive Complexity from 54 to the 15 allowed.
  • Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed.
Attachment

Re: Patch for SonarQube code scan fixes.

From
Akshay Joshi
Date:
Thanks, patch applied.

On Mon, Aug 17, 2020 at 11:17 AM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:
Hi Team,

I have fixed some code smell issues in the SonarQube scan, PFA patch.
Details as follows:

1. languages:
  • Refactor this function to reduce its Cognitive Complexity from 33 to the 15 allowed.
2. foreign table:
  • Refactor this function to reduce its Cognitive Complexity from 73 to the 15 allowed.
3. schema_diff_utils:
  • Refactor this function to reduce its Cognitive Complexity from 30 to the 15 allowed.
4. schema utils:
  • Refactor this function to reduce its Cognitive Complexity from 23 to the 15 allowed.
  • Refactor this function to reduce its Cognitive Complexity from 38 to the 15 allowed.
5. schema views:
  • Refactor this function to reduce its Cognitive Complexity from 18 to the 15 allowed.
6. schema diff directory_compare:
  • Refactor this function to reduce its Cognitive Complexity from 54 to the 15 allowed.
  • Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed.


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246