Thread: pgAdmin 4 commit: Ensure that the original file format should be retain
Ensure that the original file format should be retained when saving the same file in SQL editor. Fixes #3767 Branch ------ master Details ------- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=43e127de3167311c4e65654cd1a6f2059ea14d50 Author: Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> Modified Files -------------- docs/en_US/release_notes_4_25.rst | 1 + web/pgadmin/misc/file_manager/__init__.py | 7 +++++++ web/pgadmin/tools/sqleditor/__init__.py | 12 +++++++++++- 3 files changed, 19 insertions(+), 1 deletion(-)
Re: pgAdmin 4 commit: Ensure that the original file format should be retain
From
Murtuza Zabuawala
Date:
Hi Yogesh,
I see one problem with the given solution, if a user opens two files from two different locations with the same name but with different encoding then the backend dict mapper (filename -> encoding) will be overridden by the later filename.
On Mon, Aug 3, 2020 at 1:18 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Ensure that the original file format should be retained when saving the same file in SQL editor. Fixes #3767
Branch
------
master
Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=43e127de3167311c4e65654cd1a6f2059ea14d50
Author: Yogesh Mahajan <yogesh.mahajan@enterprisedb.com>
Modified Files
--------------
docs/en_US/release_notes_4_25.rst | 1 +
web/pgadmin/misc/file_manager/__init__.py | 7 +++++++
web/pgadmin/tools/sqleditor/__init__.py | 12 +++++++++++-
3 files changed, 19 insertions(+), 1 deletion(-)