Thread: [pgAdmin][SonarQube] Reduce cognitive complexity
Hi Hackers,
Attached is the patch to reduce cognitive complexity for:
1) web/.../databases/schemas/views/__init__.py from 110 to the 15 allowed.2) web/.../servers/databases/casts/__init__.py from 18 to the 15 allowed.
3) web/.../databases/schemas/collations/__init__.py from 16 to the 15 allowed.
Please review.
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"
Attachment
Hi Hackers,
Please ignore the previous patch. Attached is the latest.
On Mon, Jul 27, 2020 at 10:42 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,Attached is the patch to reduce cognitive complexity for:1) web/.../databases/schemas/views/__init__.py from 110 to the 15 allowed.
2) web/.../servers/databases/casts/__init__.py from 18 to the 15 allowed.
3) web/.../databases/schemas/collations/__init__.py from 16 to the 15 allowed.Please review.--Thanks,Aditya ToshniwalpgAdmin hacker | Sr. Software Engineer | edbpostgres.com"Don't Complain about Heat, Plant a TREE"
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"
Attachment
Thanks, patch applied.
On Mon, Jul 27, 2020 at 11:00 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,Please ignore the previous patch. Attached is the latest.On Mon, Jul 27, 2020 at 10:42 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi Hackers,Attached is the patch to reduce cognitive complexity for:1) web/.../databases/schemas/views/__init__.py from 110 to the 15 allowed.
2) web/.../servers/databases/casts/__init__.py from 18 to the 15 allowed.
3) web/.../databases/schemas/collations/__init__.py from 16 to the 15 allowed.Please review.--Thanks,Aditya ToshniwalpgAdmin hacker | Sr. Software Engineer | edbpostgres.com"Don't Complain about Heat, Plant a TREE"--Thanks,Aditya ToshniwalpgAdmin hacker | Sr. Software Engineer | edbpostgres.com"Don't Complain about Heat, Plant a TREE"
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
EDB PostgresMobile: +91 976-788-8246