Thread: Fix a typo in slot.c
Hi, I've attached the patch for $subject. The old comment seems to be borrowed from WalSndShmemInit(). Regards, -- Masahiko Sawada http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Attachment
On Fri, May 15, 2020 at 9:16 AM Masahiko Sawada <masahiko.sawada@2ndquadrant.com> wrote: > > Hi, > > I've attached the patch for $subject. The old comment seems to be > borrowed from WalSndShmemInit(). > /* - * Allocate and initialize walsender-related shared memory. + * Allocate and initialize replication slots' shared memory. */ How about changing it to "Allocate and initialize shared memory for replication slots"? -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
On Fri, 15 May 2020 at 13:26, Amit Kapila <amit.kapila16@gmail.com> wrote: > > On Fri, May 15, 2020 at 9:16 AM Masahiko Sawada > <masahiko.sawada@2ndquadrant.com> wrote: > > > > Hi, > > > > I've attached the patch for $subject. The old comment seems to be > > borrowed from WalSndShmemInit(). > > > > /* > - * Allocate and initialize walsender-related shared memory. > + * Allocate and initialize replication slots' shared memory. > */ > > How about changing it to "Allocate and initialize shared memory for > replication slots"? > Agreed. Attached the updated patch. Regards, -- Masahiko Sawada http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Attachment
On Fri, May 15, 2020 at 10:08 AM Masahiko Sawada <masahiko.sawada@2ndquadrant.com> wrote: > > On Fri, 15 May 2020 at 13:26, Amit Kapila <amit.kapila16@gmail.com> wrote: > > > > > > /* > > - * Allocate and initialize walsender-related shared memory. > > + * Allocate and initialize replication slots' shared memory. > > */ > > > > How about changing it to "Allocate and initialize shared memory for > > replication slots"? > > > > Agreed. > > Attached the updated patch. > Pushed. -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
On Mon, 18 May 2020 at 13:59, Amit Kapila <amit.kapila16@gmail.com> wrote: > > On Fri, May 15, 2020 at 10:08 AM Masahiko Sawada > <masahiko.sawada@2ndquadrant.com> wrote: > > > > On Fri, 15 May 2020 at 13:26, Amit Kapila <amit.kapila16@gmail.com> wrote: > > > > > > > > > /* > > > - * Allocate and initialize walsender-related shared memory. > > > + * Allocate and initialize replication slots' shared memory. > > > */ > > > > > > How about changing it to "Allocate and initialize shared memory for > > > replication slots"? > > > > > > > Agreed. > > > > Attached the updated patch. > > > > Pushed. Thank you! Regards, -- Masahiko Sawada http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services