Postgres Pro
Downloads
Home   >   mailing lists

Thread: RM5525: Cleanup and refactor the macOS build scripts

RM5525: Cleanup and refactor the macOS build scripts

From
Dave Page
Date:
Patch attached. Please review, but do not commit as this change will require that PGADMIN_PYTHON_DIR is set on the build systems.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment

Re: RM5525: Cleanup and refactor the macOS build scripts

From
Akshay Joshi
Date:
Hi Dave

Unable to apply the patch. Tried from pgadmin source folder as well as from the pkg folder.
I run git apply <patch_file>.

On Thu, May 14, 2020 at 7:01 PM Dave Page <dpage@pgadmin.org> wrote:
Patch attached. Please review, but do not commit as this change will require that PGADMIN_PYTHON_DIR is set on the build systems.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

Re: RM5525: Cleanup and refactor the macOS build scripts

From
Dave Page
Date:
patch -p0 < ~/Downloads/RM5525.patch

On Fri, May 15, 2020 at 6:46 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Dave

Unable to apply the patch. Tried from pgadmin source folder as well as from the pkg folder.
I run git apply <patch_file>.

On Thu, May 14, 2020 at 7:01 PM Dave Page <dpage@pgadmin.org> wrote:
Patch attached. Please review, but do not commit as this change will require that PGADMIN_PYTHON_DIR is set on the build systems.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: RM5525: Cleanup and refactor the macOS build scripts

From
Akshay Joshi
Date:
Hi Dave

Following are my review comments:
  • Code alignment is needed for some places in build-functions.sh. I have shellcheck installed in PyCharm and it is showing too many warnings in this file, not sure we should fix those or not  
  • Following files are empty files we should remove them and also remove the reference from the build.sh:framework_config
    codesign_binaries
    codesign_bundle
    create_dmg
    codesign_dmg



On Fri, May 15, 2020 at 1:51 PM Dave Page <dpage@pgadmin.org> wrote:
patch -p0 < ~/Downloads/RM5525.patch

On Fri, May 15, 2020 at 6:46 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Dave

Unable to apply the patch. Tried from pgadmin source folder as well as from the pkg folder.
I run git apply <patch_file>.

On Thu, May 14, 2020 at 7:01 PM Dave Page <dpage@pgadmin.org> wrote:
Patch attached. Please review, but do not commit as this change will require that PGADMIN_PYTHON_DIR is set on the build systems.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

Re: RM5525: Cleanup and refactor the macOS build scripts

From
Dave Page
Date:
Hi

On Fri, May 15, 2020 at 12:37 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Dave

Following are my review comments:
  • Code alignment is needed for some places in build-functions.sh. I have shellcheck installed in PyCharm and it is showing too many warnings in this file, not sure we should fix those or not  
OK 
  • Following files are empty files we should remove them and also remove the reference from the build.sh:framework_config
    codesign_binaries
    codesign_bundle
    create_dmg
    codesign_dmg
Huh, odd. They are removed in my env. The patch must have done something weird.

Thanks!

 



On Fri, May 15, 2020 at 1:51 PM Dave Page <dpage@pgadmin.org> wrote:
patch -p0 < ~/Downloads/RM5525.patch

On Fri, May 15, 2020 at 6:46 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Dave

Unable to apply the patch. Tried from pgadmin source folder as well as from the pkg folder.
I run git apply <patch_file>.

On Thu, May 14, 2020 at 7:01 PM Dave Page <dpage@pgadmin.org> wrote:
Patch attached. Please review, but do not commit as this change will require that PGADMIN_PYTHON_DIR is set on the build systems.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company