Thread: [pgAdmin4][Patch] - RM 5422 - Synonym Dependencies tab showsincorrect data
[pgAdmin4][Patch] - RM 5422 - Synonym Dependencies tab showsincorrect data
From
Khushboo Vashi
Date:
Hi,
Please find the attached patch to fix the RM 5422 - Synonym Dependencies tab shows incorrect data.
Thanks,
Khushboo
Attachment
Re: [pgAdmin4][Patch] - RM 5422 - Synonym Dependencies tab showsincorrect data
From
navnath gadakh
Date:
Hi ,
I'm reviewing this task.
On Wed, Apr 29, 2020 at 9:36 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,Please find the attached patch to fix the RM 5422 - Synonym Dependencies tab shows incorrect data.Thanks,Khushboo
Regards,
Navnath Gadakh
Re: [pgAdmin4][Patch] - RM 5422 - Synonym Dependencies tab showsincorrect data
From
navnath gadakh
Date:
Hi Khushboo,
Patch looks good to me except there are no API test cases written for dependents and dependencies.
Thanks!
On Wed, Apr 29, 2020 at 10:40 AM navnath gadakh <navnath.gadakh@enterprisedb.com> wrote:
Hi ,I'm reviewing this task.On Wed, Apr 29, 2020 at 9:36 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:Hi,Please find the attached patch to fix the RM 5422 - Synonym Dependencies tab shows incorrect data.Thanks,Khushboo--Regards,Navnath Gadakh
Regards,
Navnath Gadakh
Re: [pgAdmin4][Patch] - RM 5422 - Synonym Dependencies tab showsincorrect data
From
Khushboo Vashi
Date:
Hi Navnath,
On Wed, Apr 29, 2020 at 12:16 PM navnath gadakh <navnath.gadakh@enterprisedb.com> wrote:
Hi Khushboo,Patch looks good to me except there are no API test cases written for dependents and dependencies.
Thanks for the review.
We don't have API test cases for dependents and dependencies for none of the objects.
If the team agrees, I will create a separate RM for that.
Thanks,
Khushboo
Thanks!On Wed, Apr 29, 2020 at 10:40 AM navnath gadakh <navnath.gadakh@enterprisedb.com> wrote:Hi ,I'm reviewing this task.On Wed, Apr 29, 2020 at 9:36 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:Hi,Please find the attached patch to fix the RM 5422 - Synonym Dependencies tab shows incorrect data.Thanks,Khushboo--Regards,Navnath Gadakh--Regards,Navnath Gadakh
Re: [pgAdmin4][Patch] - RM 5422 - Synonym Dependencies tab showsincorrect data
From
Akshay Joshi
Date:
Thanks, patch applied.
On Wed, Apr 29, 2020 at 1:29 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Navnath,On Wed, Apr 29, 2020 at 12:16 PM navnath gadakh <navnath.gadakh@enterprisedb.com> wrote:Hi Khushboo,Patch looks good to me except there are no API test cases written for dependents and dependencies.Thanks for the review.We don't have API test cases for dependents and dependencies for none of the objects.If the team agrees, I will create a separate RM for that.Thanks,KhushbooThanks!On Wed, Apr 29, 2020 at 10:40 AM navnath gadakh <navnath.gadakh@enterprisedb.com> wrote:Hi ,I'm reviewing this task.On Wed, Apr 29, 2020 at 9:36 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:Hi,Please find the attached patch to fix the RM 5422 - Synonym Dependencies tab shows incorrect data.Thanks,Khushboo--Regards,Navnath Gadakh--Regards,Navnath Gadakh
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246