Thread: [pgAdmin4][Patch] - Improve LDAP Error messages

[pgAdmin4][Patch] - Improve LDAP Error messages

From
Khushboo Vashi
Date:
Hi,

Please find the attached patch to improve the ldap error messages.

Thanks,
Khushboo 
Attachment

Re: [pgAdmin4][Patch] - Improve LDAP Error messages

From
Akshay Joshi
Date:
Hi Khushboo

We should use the format() method instead of %. As it may create problems in translation. 
Please fix and resend the patch.

On Mon, Apr 27, 2020 at 9:30 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch to improve the ldap error messages.

Thanks,
Khushboo 


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

Re: [pgAdmin4][Patch] - Improve LDAP Error messages

From
Khushboo Vashi
Date:
Hi Akshay,

Please find the attached updated patch.
This patch also fixes the RM #5439 - User can not create server if login done with LDAP.

Thanks,
Khushboo


On Mon, Apr 27, 2020 at 1:46 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Khushboo

We should use the format() method instead of %. As it may create problems in translation. 
Please fix and resend the patch.

On Mon, Apr 27, 2020 at 9:30 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch to improve the ldap error messages.

Thanks,
Khushboo 


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246
Attachment

Re: [pgAdmin4][Patch] - Improve LDAP Error messages

From
Akshay Joshi
Date:
Thanks, patch applied.

On Mon, Apr 27, 2020 at 3:07 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Akshay,

Please find the attached updated patch.
This patch also fixes the RM #5439 - User can not create server if login done with LDAP.

Thanks,
Khushboo


On Mon, Apr 27, 2020 at 1:46 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Khushboo

We should use the format() method instead of %. As it may create problems in translation. 
Please fix and resend the patch.

On Mon, Apr 27, 2020 at 9:30 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch to improve the ldap error messages.

Thanks,
Khushboo 


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246