Thread: [pgAdmin][RM3269] Slider jumps up issue in DataView panel

Hi Hackers,

The attached patch fixes an issue where slider jumps up when new rows get loaded while scrolling down in the DataView panel in the query tool.

Fix uses rows_affected field to create dummy rows (Apart from the first batch of rows). Dummy rows will be updated as and when they are required. As total required rows are created initially, SlickGrid will not readjust its height when the next batch of rows are loaded. Hence the jump up in the slider will not happen.

--

Thanks,

Nagesh

Thanks, patch applied.

On Tue, Apr 21, 2020 at 12:10 PM Nagesh Dhope <nagesh.dhope@enterprisedb.com> wrote:

Hi Hackers,

The attached patch fixes an issue where slider jumps up when new rows get loaded while scrolling down in the DataView panel in the query tool.

Fix uses rows_affected field to create dummy rows (Apart from the first batch of rows). Dummy rows will be updated as and when they are required. As total required rows are created initially, SlickGrid will not readjust its height when the next batch of rows are loaded. Hence the jump up in the slider will not happen.

--

Thanks,

Nagesh

--

Thanks & Regards

Akshay Joshi

Sr. Software Architect

EnterpriseDB Software India Private Limited

Mobile: +91 976-788-8246

Hi Hackers,

The attached patch makes an API call to fetch the next batch of rows only after a user stops scrolling down(to detect added timeout of 250ms) using the slider.

On Tue, Apr 21, 2020 at 1:32 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Thanks, patch applied.

On Tue, Apr 21, 2020 at 12:10 PM Nagesh Dhope <nagesh.dhope@enterprisedb.com> wrote:

Hi Hackers,

The attached patch fixes an issue where slider jumps up when new rows get loaded while scrolling down in the DataView panel in the query tool.

Fix uses rows_affected field to create dummy rows (Apart from the first batch of rows). Dummy rows will be updated as and when they are required. As total required rows are created initially, SlickGrid will not readjust its height when the next batch of rows are loaded. Hence the jump up in the slider will not happen.

--

Thanks,

Nagesh

--

Thanks & Regards

Akshay Joshi

Sr. Software Architect

EnterpriseDB Software India Private Limited

Mobile: +91 976-788-8246

--

Thanks,

Nagesh

Thanks, patch applied.

On Wed, Apr 22, 2020 at 5:38 PM Nagesh Dhope <nagesh.dhope@enterprisedb.com> wrote:

Hi Hackers,

The attached patch makes an API call to fetch the next batch of rows only after a user stops scrolling down(to detect added timeout of 250ms) using the slider.

On Tue, Apr 21, 2020 at 1:32 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Thanks, patch applied.

On Tue, Apr 21, 2020 at 12:10 PM Nagesh Dhope <nagesh.dhope@enterprisedb.com> wrote:

Hi Hackers,

The attached patch fixes an issue where slider jumps up when new rows get loaded while scrolling down in the DataView panel in the query tool.

Fix uses rows_affected field to create dummy rows (Apart from the first batch of rows). Dummy rows will be updated as and when they are required. As total required rows are created initially, SlickGrid will not readjust its height when the next batch of rows are loaded. Hence the jump up in the slider will not happen.

--

Thanks,

Nagesh

--

Thanks & Regards

Akshay Joshi

Sr. Software Architect

EnterpriseDB Software India Private Limited

Mobile: +91 976-788-8246

--

Thanks,

Nagesh

--

Thanks & Regards

Akshay Joshi

Sr. Software Architect

EnterpriseDB Software India Private Limited

Mobile: +91 976-788-8246

Hi Hackers,

After fixing the issue reported by Shubham, I observed that sometimes browser is getting hanged and sometimes ViewData grid is getting disappear, I suspect its due to the number of rows to update on slick grid after fetching next of rows. FYI, I was running a query which was returning 1000100 rows and 3 columns. I tried fixing it but I didn't find any feasible solution.

As there is workaround provided for RM3269 by Dave. I would suggest, we shall revert the already applied patches. Please find the attached patch for the same.

On Wed, Apr 22, 2020 at 6:49 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Thanks, patch applied.

On Wed, Apr 22, 2020 at 5:38 PM Nagesh Dhope <nagesh.dhope@enterprisedb.com> wrote:

Hi Hackers,

The attached patch makes an API call to fetch the next batch of rows only after a user stops scrolling down(to detect added timeout of 250ms) using the slider.

On Tue, Apr 21, 2020 at 1:32 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Thanks, patch applied.

On Tue, Apr 21, 2020 at 12:10 PM Nagesh Dhope <nagesh.dhope@enterprisedb.com> wrote:

Hi Hackers,

The attached patch fixes an issue where slider jumps up when new rows get loaded while scrolling down in the DataView panel in the query tool.

Fix uses rows_affected field to create dummy rows (Apart from the first batch of rows). Dummy rows will be updated as and when they are required. As total required rows are created initially, SlickGrid will not readjust its height when the next batch of rows are loaded. Hence the jump up in the slider will not happen.

--

Thanks,

Nagesh

--

Thanks & Regards

Akshay Joshi

Sr. Software Architect

EnterpriseDB Software India Private Limited

Mobile: +91 976-788-8246

--

Thanks,

Nagesh

--

Thanks & Regards

Akshay Joshi

Sr. Software Architect

EnterpriseDB Software India Private Limited

Mobile: +91 976-788-8246

--

Thanks,

Nagesh