Fixed following issues for Procedures:
1) Change comments on the procedure with arguments as a procedure can be overloaded.
Note that on EPAS servers, procedure overloading works only for v11+.
2) The save button of a procedure dialog is enabled without any change.
3) Fixed formatting of the reverse-engineered SQL.
4) On EPAS servers, the parameters set were not displayed in the SQL generated.
They are visible only if set to edbsql.
5) Changing the volatility option of any existing procedure was not working.
6) Changing the parallel option (EPAS v9.6+) was not working.
7) Added RE-SQL test cases for procedures.
Fixes #4620, Fixes #4873
Branch
------
master
Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0424f7d962188a7373668ace58b56365017df6fd
Author: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>
Modified Files
--------------
docs/en_US/release_notes_4_21.rst | 2 +
.../databases/schemas/functions/__init__.py | 22 ++-
.../schemas/functions/static/js/procedure.js | 10 +-
.../templates/procedures/pg/sql/11_plus/create.sql | 9 +-
.../templates/procedures/pg/sql/11_plus/update.sql | 2 +-
.../procedures/ppas/sql/11_plus/create.sql | 10 +-
.../procedures/ppas/sql/11_plus/update.sql | 2 +-
.../procedures/ppas/sql/9.5_plus/create.sql | 2 +-
.../procedures/ppas/sql/9.5_plus/update.sql | 5 +-
.../procedures/ppas/sql/9.6_plus/create.sql | 4 +-
.../procedures/ppas/sql/9.6_plus/properties.sql | 46 +++++
.../procedures/ppas/sql/9.6_plus/update.sql | 6 +-
.../tests/pg/11_plus/alter_proc_comment.sql | 13 ++
.../tests/pg/11_plus/alter_proc_comment_msql.sql | 2 +
.../tests/pg/11_plus/alter_proc_param.sql | 14 ++
.../tests/pg/11_plus/alter_proc_param_msql.sql | 2 +
.../tests/pg/11_plus/alter_ptrig_comment.sql | 18 ++
.../tests/pg/11_plus/alter_ptrig_set_1.sql | 18 ++
.../tests/pg/11_plus/alter_ptrig_set_2.sql | 20 +++
.../tests/pg/11_plus/alter_ptrig_set_3.sql | 21 +++
.../tests/pg/11_plus/create_event_trigger_full.sql | 24 +++
.../tests/pg/11_plus/create_plain_trigger.sql | 15 ++
.../tests/pg/11_plus/create_plain_trigger_full.sql | 25 +++
.../tests/pg/11_plus/create_procedure.sql | 10 ++
.../tests/pg/11_plus/test_procedures.json | 58 +++++++
.../tests/pg/11_plus/test_trigger_functions.json | 191 +++++++++++++++++++++
.../tests/ppas/11_plus/alter_proc_comment.sql | 13 ++
.../tests/ppas/11_plus/alter_proc_comment_msql.sql | 2 +
.../tests/ppas/11_plus/alter_proc_param.sql | 14 ++
.../tests/ppas/11_plus/alter_proc_param_msql.sql | 2 +
.../tests/ppas/11_plus/alter_ptrig_comment.sql | 18 ++
.../tests/ppas/11_plus/alter_ptrig_set_1.sql | 18 ++
.../tests/ppas/11_plus/alter_ptrig_set_2.sql | 20 +++
.../tests/ppas/11_plus/alter_ptrig_set_3.sql | 21 +++
.../ppas/11_plus/create_event_trigger_full.sql | 20 +++
.../tests/ppas/11_plus/create_plain_trigger.sql | 15 ++
.../ppas/11_plus/create_plain_trigger_full.sql | 21 +++
.../tests/ppas/11_plus/create_procedure.sql | 10 ++
.../tests/ppas/11_plus/test_procedures.json | 58 +++++++
.../tests/ppas/11_plus/test_trigger_functions.json | 171 ++++++++++++++++++
.../tests/ppas/9.6_plus/alter_proc_comment.sql | 14 ++
.../ppas/9.6_plus/alter_proc_comment_msql.sql | 2 +
.../tests/ppas/9.6_plus/alter_proc_opt.sql | 15 ++
.../tests/ppas/9.6_plus/alter_proc_opt_msql.sql | 15 ++
.../tests/ppas/9.6_plus/alter_proc_param.sql | 15 ++
.../tests/ppas/9.6_plus/alter_proc_param_msql.sql | 2 +
.../tests/ppas/9.6_plus/alter_ptrig_comment.sql | 18 ++
.../tests/ppas/9.6_plus/alter_ptrig_set_1.sql | 18 ++
.../tests/ppas/9.6_plus/alter_ptrig_set_2.sql | 20 +++
.../tests/ppas/9.6_plus/alter_ptrig_set_3.sql | 21 +++
.../ppas/9.6_plus/create_event_trigger_full.sql | 20 +++
.../tests/ppas/9.6_plus/create_plain_trigger.sql | 15 ++
.../ppas/9.6_plus/create_plain_trigger_full.sql | 21 +++
.../tests/ppas/9.6_plus/create_procedure.sql | 11 ++
.../tests/ppas/9.6_plus/test_procedures.json | 71 ++++++++
.../ppas/9.6_plus/test_trigger_functions.json | 171 ++++++++++++++++++
.../tests/ppas/default/alter_proc_comment.sql | 14 ++
.../tests/ppas/default/alter_proc_comment_msql.sql | 2 +
.../tests/ppas/default/alter_proc_opt.sql | 15 ++
.../tests/ppas/default/alter_proc_opt_msql.sql | 15 ++
.../tests/ppas/default/alter_proc_param.sql | 15 ++
.../tests/ppas/default/alter_proc_param_msql.sql | 2 +
.../tests/ppas/default/create_procedure.sql | 11 ++
.../tests/ppas/default/test_procedures.json | 71 ++++++++
64 files changed, 1511 insertions(+), 37 deletions(-)
