Thread: [pgAdmin4][RM#4858] Allow user to reconnect to DB server whenconnection is drop

[pgAdmin4][RM#4858] Allow user to reconnect to DB server whenconnection is drop

From
Murtuza Zabuawala
Date:
Hi,

Upon downloading the csv file, we used the prompt for re-connecting to the database server when there is a database server connection issue. Currently the user tries to download CSV and there is a connection issue then it is showing a python exception error.

Steps:
1) Open query tool
2) Execute -> SELECT 1,2,3
3) Disconnect from server from browser tree
4) Click on Download CSV button

Current: Python exception error
Expected: It should display dialog to reconnect the server.


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment
Hi Murtuza

The issue has been fixed with your patch, but there is an existing issue discover with the fix.
After disconnecting the server and click on Download CSV button confirmation dialog comes and user needs to click twice. 
Following error observed in the browser:

sqleditor.js?ver=42000:1 Uncaught TypeError: Cannot read property 'apply' of undefined
    at Object.<anonymous> (sqleditor.js?ver=42000:1)
    at Object.callback (vendor.others.js?ver=42000:2)
    at Tt (vendor.others.js?ver=42000:2)
    at Object.Ct (vendor.others.js?ver=42000:2)
    at HTMLDivElement.<anonymous> (vendor.others.js?ver=42000:2)

If possible can you please fix the above and resend the combined patch.

On Fri, Apr 10, 2020 at 7:02 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

Upon downloading the csv file, we used the prompt for re-connecting to the database server when there is a database server connection issue. Currently the user tries to download CSV and there is a connection issue then it is showing a python exception error.

Steps:
1) Open query tool
2) Execute -> SELECT 1,2,3
3) Disconnect from server from browser tree
4) Click on Download CSV button

Current: Python exception error
Expected: It should display dialog to reconnect the server.


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

Re: [pgAdmin4][RM#4858] Allow user to reconnect to DB server whenconnection is drop

From
Murtuza Zabuawala
Date:
Hi Akshay,

PFA updated patch.


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



On Mon, Apr 13, 2020 at 2:28 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Murtuza

The issue has been fixed with your patch, but there is an existing issue discover with the fix.
After disconnecting the server and click on Download CSV button confirmation dialog comes and user needs to click twice. 
Following error observed in the browser:

sqleditor.js?ver=42000:1 Uncaught TypeError: Cannot read property 'apply' of undefined
    at Object.<anonymous> (sqleditor.js?ver=42000:1)
    at Object.callback (vendor.others.js?ver=42000:2)
    at Tt (vendor.others.js?ver=42000:2)
    at Object.Ct (vendor.others.js?ver=42000:2)
    at HTMLDivElement.<anonymous> (vendor.others.js?ver=42000:2)

If possible can you please fix the above and resend the combined patch.

On Fri, Apr 10, 2020 at 7:02 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

Upon downloading the csv file, we used the prompt for re-connecting to the database server when there is a database server connection issue. Currently the user tries to download CSV and there is a connection issue then it is showing a python exception error.

Steps:
1) Open query tool
2) Execute -> SELECT 1,2,3
3) Disconnect from server from browser tree
4) Click on Download CSV button

Current: Python exception error
Expected: It should display dialog to reconnect the server.


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246
Attachment
Thanks, patch applied.

On Wed, Apr 15, 2020 at 12:22 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Akshay,

PFA updated patch.


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



On Mon, Apr 13, 2020 at 2:28 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Murtuza

The issue has been fixed with your patch, but there is an existing issue discover with the fix.
After disconnecting the server and click on Download CSV button confirmation dialog comes and user needs to click twice. 
Following error observed in the browser:

sqleditor.js?ver=42000:1 Uncaught TypeError: Cannot read property 'apply' of undefined
    at Object.<anonymous> (sqleditor.js?ver=42000:1)
    at Object.callback (vendor.others.js?ver=42000:2)
    at Tt (vendor.others.js?ver=42000:2)
    at Object.Ct (vendor.others.js?ver=42000:2)
    at HTMLDivElement.<anonymous> (vendor.others.js?ver=42000:2)

If possible can you please fix the above and resend the combined patch.

On Fri, Apr 10, 2020 at 7:02 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

Upon downloading the csv file, we used the prompt for re-connecting to the database server when there is a database server connection issue. Currently the user tries to download CSV and there is a connection issue then it is showing a python exception error.

Steps:
1) Open query tool
2) Execute -> SELECT 1,2,3
3) Disconnect from server from browser tree
4) Click on Download CSV button

Current: Python exception error
Expected: It should display dialog to reconnect the server.


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246