Thread: [pgAdmin4][Patch] - RM 5270 - [EPAS] Synonym properties does not show OID.
[pgAdmin4][Patch] - RM 5270 - [EPAS] Synonym properties does not show OID.
From
Khushboo Vashi
Date:
Hi,
Please find the attached patch to fix the RM # 5270 - [EPAS] Synonym properties does not show OID.
As per the current implementation, we completely ignored OID and instead considered the name as the unique field, now with this patch OID will be used as an unique id and also will display OID in the properties tab.
Thanks,
Khushboo
Attachment
Re: [pgAdmin4][Patch] - RM 5270 - [EPAS] Synonym properties does notshow OID.
From
Akshay Joshi
Date:
Hi Khushboo
Schema Diff test cases are failing with this patch. Please fix and resend the patch.
On Tue, Apr 7, 2020 at 6:37 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,Please find the attached patch to fix the RM # 5270 - [EPAS] Synonym properties does not show OID.As per the current implementation, we completely ignored OID and instead considered the name as the unique field, now with this patch OID will be used as an unique id and also will display OID in the properties tab.Thanks,Khushboo
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246
Re: [pgAdmin4][Patch] - RM 5270 - [EPAS] Synonym properties does notshow OID.
From
Ashesh Vashi
Date:
On Tue, Apr 7, 2020 at 6:37 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,Please find the attached patch to fix the RM # 5270 - [EPAS] Synonym properties does not show OID.As per the current implementation, we completely ignored OID and instead considered the name as the unique field, now with this patch OID will be used as an unique id and also will display OID in the properties tab.
Question is: When we rename a synonym, does it create a new OID, or keep the same?
-- Ashesh
Thanks,Khushboo
Re: [pgAdmin4][Patch] - RM 5270 - [EPAS] Synonym properties does notshow OID.
From
Khushboo Vashi
Date:
On Wed, Apr 8, 2020 at 12:40 PM Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
On Tue, Apr 7, 2020 at 6:37 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:Hi,Please find the attached patch to fix the RM # 5270 - [EPAS] Synonym properties does not show OID.As per the current implementation, we completely ignored OID and instead considered the name as the unique field, now with this patch OID will be used as an unique id and also will display OID in the properties tab.Question is: When we rename a synonym, does it create a new OID, or keep the same?
We can not rename a synonym, must drop it and recreate it.
-- AsheshThanks,Khushboo
Re: [pgAdmin4][Patch] - RM 5270 - [EPAS] Synonym properties does notshow OID.
From
Akshay Joshi
Date:
Hi Khushboo
View/MView test also failing with the commit of #5053. Please fix those as well and send a combined patch.
On Wed, Apr 8, 2020 at 12:47 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
On Wed, Apr 8, 2020 at 12:40 PM Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:On Tue, Apr 7, 2020 at 6:37 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:Hi,Please find the attached patch to fix the RM # 5270 - [EPAS] Synonym properties does not show OID.As per the current implementation, we completely ignored OID and instead considered the name as the unique field, now with this patch OID will be used as an unique id and also will display OID in the properties tab.Question is: When we rename a synonym, does it create a new OID, or keep the same?We can not rename a synonym, must drop it and recreate it.-- AsheshThanks,Khushboo
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246
Re: [pgAdmin4][Patch] - RM 5270 - [EPAS] Synonym properties does notshow OID.
From
Khushboo Vashi
Date:
Hi Akshay,
On Wed, Apr 8, 2020 at 12:33 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi KhushbooSchema Diff test cases are failing with this patch. Please fix and resend the patch.
Can you please re-verify as I don't think schema diff test cases are failing due to this patch.
Thanks,
Khushboo
On Tue, Apr 7, 2020 at 6:37 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:Hi,Please find the attached patch to fix the RM # 5270 - [EPAS] Synonym properties does not show OID.As per the current implementation, we completely ignored OID and instead considered the name as the unique field, now with this patch OID will be used as an unique id and also will display OID in the properties tab.Thanks,Khushboo--Thanks & RegardsAkshay JoshiSr. Software ArchitectEnterpriseDB Software India Private LimitedMobile: +91 976-788-8246
Re: [pgAdmin4][Patch] - RM 5270 - [EPAS] Synonym properties does notshow OID.
From
Khushboo Vashi
Date:
Hi,
Please find the attached updated patch.
Thanks,
Khushboo
On Fri, Apr 10, 2020 at 10:41 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Akshay,On Wed, Apr 8, 2020 at 12:33 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi KhushbooSchema Diff test cases are failing with this patch. Please fix and resend the patch.
Fixed.
Thanks,
Khushboo
Can you please re-verify as I don't think schema diff test cases are failing due to this patch.Thanks,KhushbooOn Tue, Apr 7, 2020 at 6:37 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:Hi,Please find the attached patch to fix the RM # 5270 - [EPAS] Synonym properties does not show OID.As per the current implementation, we completely ignored OID and instead considered the name as the unique field, now with this patch OID will be used as an unique id and also will display OID in the properties tab.Thanks,Khushboo--Thanks & RegardsAkshay JoshiSr. Software ArchitectEnterpriseDB Software India Private LimitedMobile: +91 976-788-8246
Attachment
Re: [pgAdmin4][Patch] - RM 5270 - [EPAS] Synonym properties does notshow OID.
From
Akshay Joshi
Date:
Thanks patch applied.
On Fri, Apr 10, 2020 at 11:58 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,Please find the attached updated patch.Thanks,KhushbooOn Fri, Apr 10, 2020 at 10:41 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:Hi Akshay,On Wed, Apr 8, 2020 at 12:33 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi KhushbooSchema Diff test cases are failing with this patch. Please fix and resend the patch.Fixed.Thanks,KhushbooCan you please re-verify as I don't think schema diff test cases are failing due to this patch.Thanks,KhushbooOn Tue, Apr 7, 2020 at 6:37 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:Hi,Please find the attached patch to fix the RM # 5270 - [EPAS] Synonym properties does not show OID.As per the current implementation, we completely ignored OID and instead considered the name as the unique field, now with this patch OID will be used as an unique id and also will display OID in the properties tab.Thanks,Khushboo--Thanks & RegardsAkshay JoshiSr. Software ArchitectEnterpriseDB Software India Private LimitedMobile: +91 976-788-8246
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246