Thread: terminology in example
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/12/ddl-inherit.html Description: In the example on this page: https://www.postgresql.org/docs/current/ddl-inherit.html the word 'altitude' should be replaced with 'elevation'.
On Tue, Mar 24, 2020 at 03:57:25PM +0000, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/12/ddl-inherit.html > Description: > > In the example on this page: > https://www.postgresql.org/docs/current/ddl-inherit.html > the word 'altitude' should be replaced with 'elevation'. Yes, I see your point: https://mapscaping.com/blogs/geo-candy/what-is-the-difference-between-elevation-relief-and-altitude -- Bruce Momjian <bruce@momjian.us> https://momjian.us EnterpriseDB https://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +
On Tue, Mar 24, 2020 at 01:41:41PM -0400, Bruce Momjian wrote: > On Tue, Mar 24, 2020 at 03:57:25PM +0000, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > > > Page: https://www.postgresql.org/docs/12/ddl-inherit.html > > Description: > > > > In the example on this page: > > https://www.postgresql.org/docs/current/ddl-inherit.html > > the word 'altitude' should be replaced with 'elevation'. > > Yes, I see your point: > > https://mapscaping.com/blogs/geo-candy/what-is-the-difference-between-elevation-relief-and-altitude The attached patch fixes the problem. The regression tests also have many mentions of "altitude." Should those be changed too? -- Bruce Momjian <bruce@momjian.us> https://momjian.us EnterpriseDB https://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +
Attachment
On Tue, 2020-03-31 at 19:10 -0400, Bruce Momjian wrote: > The attached patch fixes the problem. The regression tests also have > many mentions of "altitude." Should those be changed too? I don't think that is necessary. Names don't matter in the regression tests. > --- a/doc/src/sgml/advanced.sgml > +++ b/doc/src/sgml/advanced.sgml > @@ -585,20 +585,20 @@ SELECT sum(salary) OVER w, avg(salary) OVER w > CREATE TABLE capitals ( > name text, > population real, > - altitude int, -- (in ft) > + elevation int, -- (in ft) > state char(2) > ); > > CREATE TABLE non_capitals ( > name text, > population real, > - altitude int -- (in ft) > + elevation int -- (in ft) > ); > > @@ -612,7 +612,7 @@ CREATE VIEW cities AS > CREATE TABLE cities ( > name text, > population real, > - altitude int -- (in ft) > + elevation int -- (in ft) > ); The "int" should be aligned with the rest (delete one space). Yours, Laurenz Albe
On Wed, Apr 1, 2020 at 08:37:30AM +0200, Laurenz Albe wrote: > On Tue, 2020-03-31 at 19:10 -0400, Bruce Momjian wrote: > > > The attached patch fixes the problem. The regression tests also have > > many mentions of "altitude." Should those be changed too? > > I don't think that is necessary. > Names don't matter in the regression tests. Agreed. > > @@ -612,7 +612,7 @@ CREATE VIEW cities AS > > CREATE TABLE cities ( > > name text, > > population real, > > - altitude int -- (in ft) > > + elevation int -- (in ft) > > ); > > The "int" should be aligned with the rest (delete one space). Fixed, thanks. -- Bruce Momjian <bruce@momjian.us> https://momjian.us EnterpriseDB https://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +
Patch applied back to 9.5, thanks. --------------------------------------------------------------------------- On Wed, Apr 1, 2020 at 08:27:59PM -0400, Bruce Momjian wrote: > On Wed, Apr 1, 2020 at 08:37:30AM +0200, Laurenz Albe wrote: > > On Tue, 2020-03-31 at 19:10 -0400, Bruce Momjian wrote: > > > > > The attached patch fixes the problem. The regression tests also have > > > many mentions of "altitude." Should those be changed too? > > > > I don't think that is necessary. > > Names don't matter in the regression tests. > > Agreed. > > > > @@ -612,7 +612,7 @@ CREATE VIEW cities AS > > > CREATE TABLE cities ( > > > name text, > > > population real, > > > - altitude int -- (in ft) > > > + elevation int -- (in ft) > > > ); > > > > The "int" should be aligned with the rest (delete one space). > > Fixed, thanks. > > -- > Bruce Momjian <bruce@momjian.us> https://momjian.us > EnterpriseDB https://enterprisedb.com > > + As you are, so once was I. As I am, so you will be. + > + Ancient Roman grave inscription + > > -- Bruce Momjian <bruce@momjian.us> https://momjian.us EnterpriseDB https://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +