Thread: pgsql: Silence compiler warning in nbtinsert.c.

pgsql: Silence compiler warning in nbtinsert.c.

From
Peter Geoghegan
Date:
Silence compiler warning in nbtinsert.c.

Per buildfarm member longfin.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2d8a6fad18fcec1850b79ddcf3a0032058d86715

Modified Files
--------------
src/backend/access/nbtree/nbtinsert.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


Re: pgsql: Silence compiler warning in nbtinsert.c.

From
Alvaro Herrera
Date:
On 2020-Feb-26, Peter Geoghegan wrote:

> Silence compiler warning in nbtinsert.c.
> 
> Per buildfarm member longfin.

I'm seeing another one:

/pgsql/source/master/src/backend/access/nbtree/nbtinsert.c: In function '_bt_insertonpg':
/pgsql/source/master/src/backend/access/nbtree/nbtinsert.c:1231:4: warning: 'oposting' may be used uninitialized in
thisfunction [-Wmaybe-uninitialized]
 
    memcpy(oposting, nposting, MAXALIGN(IndexTupleSize(nposting)));
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Thanks

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



Re: pgsql: Silence compiler warning in nbtinsert.c.

From
Peter Geoghegan
Date:
On Wed, Feb 26, 2020 at 3:07 PM Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> I'm seeing another one:
>
> /pgsql/source/master/src/backend/access/nbtree/nbtinsert.c: In function '_bt_insertonpg':
> /pgsql/source/master/src/backend/access/nbtree/nbtinsert.c:1231:4: warning: 'oposting' may be used uninitialized in
thisfunction [-Wmaybe-uninitialized]
 
>     memcpy(oposting, nposting, MAXALIGN(IndexTupleSize(nposting)));
>     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Fixed - Thanks.

-- 
Peter Geoghegan