Thread: pgsql: Add tests for tuplesort.c.
Add tests for tuplesort.c. Previously significant parts of tuplesort.c were untested. This commit, while not testing every path, significantly increases coverage. In particular, this adds tests for abbreviated key logic, forward/backward scans & scrolling and mark/restore. I tried to keep the table sizes reasonable, and stress the on-disk paths by setting work_mem to low values for specific tests. The buildfarm will tell whether more attention to test time is needed. Author: Andres Freund Discussion: https://postgr.es/m/20191013144153.ooxrfglvnaocsrx2@alap3.anarazel.de Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/4a252996d5fda7662b2afdf329a5c95be0fe3b01 Modified Files -------------- src/test/regress/expected/tuplesort.out | 691 ++++++++++++++++++++++++++++++++ src/test/regress/parallel_schedule | 2 +- src/test/regress/sql/tuplesort.sql | 304 ++++++++++++++ 3 files changed, 996 insertions(+), 1 deletion(-)
On Wed, Nov 13, 2019 at 4:09 PM Andres Freund <andres@anarazel.de> wrote: > Add tests for tuplesort.c. > Modified Files > -------------- > src/test/regress/expected/tuplesort.out | 691 ++++++++++++++++++++++++++++++++ > src/test/regress/parallel_schedule | 2 +- > src/test/regress/sql/tuplesort.sql | 304 ++++++++++++++ > 3 files changed, 996 insertions(+), 1 deletion(-) Looks like you forgot to add an entry to serial_schedule. -- Peter Geoghegan
Hi, On November 16, 2019 10:09:19 AM PST, Peter Geoghegan <pg@bowt.ie> wrote: >On Wed, Nov 13, 2019 at 4:09 PM Andres Freund <andres@anarazel.de> >wrote: >> Add tests for tuplesort.c. > >> Modified Files >> -------------- >> src/test/regress/expected/tuplesort.out | 691 >++++++++++++++++++++++++++++++++ >> src/test/regress/parallel_schedule | 2 +- >> src/test/regress/sql/tuplesort.sql | 304 ++++++++++++++ >> 3 files changed, 996 insertions(+), 1 deletion(-) > >Looks like you forgot to add an entry to serial_schedule. Indeed, thanks for catching. I'm off till Monday... If you want to push the addition... Really gotta change pg_regress to automatically serialize when setting max parallelism to 1... Andres -- Sent from my Android device with K-9 Mail. Please excuse my brevity.
On Sat, Nov 16, 2019 at 10:14 AM Andres Freund <andres@anarazel.de> wrote: > Indeed, thanks for catching. I'm off till Monday... If you want to push the addition... No problem. I'll push a fix now. -- Peter Geoghegan
On 2019-11-16 10:40:17 -0800, Peter Geoghegan wrote: > On Sat, Nov 16, 2019 at 10:14 AM Andres Freund <andres@anarazel.de> wrote: > > Indeed, thanks for catching. I'm off till Monday... If you want to push the addition... > > No problem. I'll push a fix now. Thanks!