Thread: [PATCH] 32x32 and 48x48 favicons

[PATCH] 32x32 and 48x48 favicons

From

Marcin Cieślak

Date:

05 November 2019, 10:21:21

> Bug reference:      16075
> Logged by:          Liu Linhuai
> Email address:      liulinhuai@yahoo.com
> PostgreSQL version: 12.0
> Operating system:   macOS
> Description:
>
> Hi, I am using MacBook Pro and Google Chrome to visit
> https://www.postgresql.org, the favicon on the browser's title look really
> bad. I hope it's updated for a high-resolution version.
>
---
 media/favicon.ico | Bin 2550 -> 4846 bytes
 1 file changed, 0 insertions(+), 0 deletions(-)

diff --git a/media/favicon.ico b/media/favicon.ico
index a1cc036e6f1eb96fa563c7e6e07f75548a7361be..cc0376628a0e83ab9bcb40a9af951ed03925ee4f 100644
GIT binary patch
literal 4846
zcmeHLPj4GV6rc63*Y-N=-5q<xF=bNQNlzi7t?0#0sS4bxEp31UK`w0sr?j*&;^I(&
zK%AfzDz{WYqBLJ3fe*k}NRAvia<F24Z~pAAOG?rsQlIqv=FR-(&3kX&yx3vPVJ?f~
z7}8_&4rAvSW2a7O{m&9(A7XBCkzu{cer+&z*<)-Tn3!;2+NTIuOSERG*Xyy-sK<7}
zqtOTwyi2@mA^#~`eZ8EXR?<n^TFN#~@miPU9OT81ucvZj*-5)YDeo?O@?1yCd#o(e
zj_h2Eg_3FiO?l(GJUh5@QC`0(JNI6@C;^j$(@m1?^mQ*i`&s*DyU$w7&ZSGsY%<H(
zBx3B4xWd>0cn`;K61!mJ1_}5V(fsdNr#zhk_rY17s!$A_G*1)cYBC|7*sUj$l}Ase
za2vAyePP0RAmzJ7{f?Ap3c5Fta-pcFQg#bIdsDiTklyL*4a0aiyo>$qD@w1XUkwKr
zV86Yya~m_4<wElIJoLG3`5v}xOZme)PjMOY^Cvrx8J+y;8kVKJunu^D!OwD=^zXie
z{t6r!$a_%R->xZha(+p!Kwmh&0uQ$(>1Uv?bg!;6=YFO??54Mw2g}`**5@9~FRd^Y
zNGccL{+;=yGpw=%{NRl>=(kqVZcN8_f4cP}@V~4LI(?<zxCN9v|HYuaPI^aqiv&uk
zbnUH_D9Fc^6o9Y6@b>}M9m2k^^beL~x6d{(?%b!3huFbbW#j6#wVfMtD^H~S1nFU|
z;oZb}YdCy5e6$QTCv_c@$u}qshst9zIaEA?%y_)VMt{TVUns)^>?PjA7#x8so0?rn
zVuzUJjA2fjW_=IX1MC|gF7~L-7r`HasZS`XX`w#JnxWa*Sw=l!YZZ*1u)4Ym3Eo;|
zyI|ELwnosmpo4d}*gly0#Xj*q@jjanPl#XaO;|r(%9j~<nSuXn21>Phy;k_faZDUF
z!Q+?<UOonAmdhe=L4G7owt+_k2hE5=r+e;MCE;th>+)ikeBOq#uyD75Zz9K1jc52k
z9E)bGo@99cBmvZIxUTDo6I?<8?}`%y9Od?1UOzs7B0fGkK_$AEQk}PWRAxnd$d9mJ
z;zC4DNhDzq#DYh0mLK=1gqB3?`AuFHyn(v$xXAMfJZy<%s#ZCz`>m){i$v2$4)gm0
zz7YgLgNu4rNj2fo`My9ZoT%lyt%7}DRB)v41x;=@h)}y*#RjJ=;6PSxSm4c&JQ6K?
z6UIE2w6DBTgu5ORP%4$mwVJWd8`?a1BmysNS=C5bx1LaH^J4d!DsEAo+7O6@7w@c|
zB_q^vt88UkJduc?_$+O-u4_ht-ez{dhzOGWk_+xo=7_|Mmh|aC;h~=&kh|mCG{%{S
zt{XRz(a?>v1E3i4EPf_`zCJaUR*1}*#^MyRp_>j}gEgVdyELDe6ct*5nkQrdPoW@Q
zn$vesc-lwcRjPDcE&VQY_mLOaAqum28#MA%-Wob$iy@pEdx4u|&qa^ad{sG=XP@v?
z4o%!<mj5{MlF)6c6sqzphU*H^obi1>&hIx6L5TZO=cx=8Iv?zZjTTk934>g0;5FdS
z01ef{pTbjN`@vN4Lk~lt3SI>;g)i0tSu_;rd-tg`PT{8u)52X--yW4jIgia;WCpW?
z8CzC_cdVjTlR{sxaNoWU-Kll1%%btsLP`2rZ_yQ0o<1O}1hWTS&y2jLuF#09W~FEG
zSk1B)XfS5g=cZjboSSDzkQssYW~s_`=Aj2@$EHs^k>FuasZ@h7QMZ`{C<;G-lIXo&
zz-@0+d(if&3`A5f!$>(&3bkdP;2$3e26?YFhcL$;M-vVRpY)w0dZDi!)|!?0t@0cF
zT!Gx|X~|}lJY>-`vSM^C$IMDs&5zlU@(=tdqjele@{kV3y^KlX{}K2Nh&YVI5Wfc%
zP03gF??cuzayFNHgoeE-S<(LwVOHXtO~O4ZZAPCbY0ojVY1Wm5ojua6#CZp#!w(e?
Q{2sG)MsXnDV`swHKMV<ARsaA1

literal 2550
zcmeH}X-rgC6vq#xwGC-fUmEyiGSr&Z##Wetp+IBYsnKY{7fLm#vjJ+QN?g7O#lj#A
zv%(<Oogym8CYvaNsDmsuq6KTGr7A917H4F2DwWg!8^zkjr1iTuIq#i&?>l!ncjo`Q
zL>}}SO`c5d68i?x2k@TNUner6ZMxV7^M!fPTX?#iC+`X0<4N_KH47<CF_Vl+Kgx*l
zBV#n)u`|h{@uOsgjI;_lC94A|H71DClrl2FbZQwH)ly1V%1N)1!w;hEieO4nhLBbr
zLOK;p6GA)I%%=3%U^2yq;ysJZh_z^>WYzeSMHNWqSoCY=Qu_KZ(yd!Wx(!RnuyGN6
z7r&U&wtPXmwnWg*ZC}!^gh<+-5Jh{Fq9||sO3Ku(roG7u`aVTLhtm|4Yg|VMjd4`C
zGmdi2n<?MAm5$|XrsAEOseE4oRpxG^yzCSz$<<MDeg+lgndnqOD%BNesrpa`)f_fZ
zWuXamJyqss(TQUgswuQkZIOlQOS7r2csHFX%cPpJY&u<@O$|kQI$LTc+i?ros<Nn|
zGMgGtSgE-(ht5^)B3sQK)DKeAnIqJ6>L@kU7f|z=Qfg_aq?X2N`l0a@wY8k4_Lf@e
zxL8ZA7tT_9+c~=0)<B&d=gEGhiEeauP?!A@bzQ$kcW+#!?yhTeyUR|FzHV|j`f1?)
zJsNQI(9nZk8Xk1~eYUT>R~dN845;4!Xx;N6L4w5Z`MSU0Day>V@`=RL_i05#YiC8x
zkWBLV+TAc$SVdpWnlAAamVc%sit!evu9~}45G2C<ID9ZqA}pBd6^^>^@|CE6ED^%J
zgb*KzB=EzqwG@wzWj;didlK*PX`wPwAuik_81X(!XU-95u^^Ew3y%mv^Md6Of+kEN
z2*EQv1s^m7`AZ_!dP@Wk42Uu<Oz>VsVLo173+H=#dCS7Rycc7__;~TLo+xSsJbve&
z_WPSeHt1rK=Tj3ka>C$Flq9rWQvF+Jecj!2pusO&F1OU&g8nhIj(=@$EPk2z@$vCV
zd6}DBMwN`s(Ncyk^61F$y#G6f%Qfl;9c6>YpP~N@?d74t`;q?@KRP-hb2|EC?%lf+
z2TkUzXg_y6G@XZ?y@@Z1A9D1rXss`+a60ZU`{k!g7YlRsu4Y@M3);?BtR388u!DQ=
zb{78m@Im<F$753`#u*tNTvWb4#R&#+V@-a;;DBTHjm~yE^qj#7Hbn=p5$jJ=1~4?2
z5111NYpcsHIQn~*F!S3#ceGwiRfix){;Z4poUb%j_ZRF*c0$wHtdcVr##w3^n=~@6
zDm3x!+c$G2=6>LGMuHJ+MvjacDT5OXW^t<WQ-<C%*vT2{0M14~SjW(NZnd36YKLXw
z7$ZYY1=z)4D#rI`TUi#TD1$gd70Ac;B_cKyb4wXaWH5}uJ_di--gdT7jPL9IZFjmV
z=vh4Y!@B4Y7SFsWdn<#XSeul;Mee{O216Ol<9)g{Bje+br?lFt+VsdvCiZ5;8f@ie
z2KO0^<hlwg>oIQ@42<T}<v9$#VvkznQqKK7Hxt1>_isy#Hz9vuAA^Ss&T+;51mq6;
zM(#3T;3|WA3>LCkDdj7TrFCGaJGXjG0P8SDNzNt)(;4>;Heg>Sv}eGq$bkU{hBLSh
zKY;5?thel!&$T424#qhJxDEFT26I`vTJHWvkMGRl+QjiUEMagPXCvoyg`6Afira<<
z2O_Hqj4s?oI2n1sJ%uX{Wsa2`+R=}D4JRw4tW^gy?hy=*GwwUAjSl6S!<L@0F_-%c
zA3b{H<LK=&cX!zhj=sAa$Nm_VyB>~C>Fe&a-s=3(FyOqiX?UPV(@=fHe*Waqp5E^3
j+wtFgS3EyaXU3r|qPbuVqQ;0F(3uzMi`X?$M6LM?BRCQy

-- 
2.23.0

Re: [PATCH] 32x32 and 48x48 favicons

From

"Jonathan S. Katz"

Date:

06 November 2019, 19:58:09

Hi Marcin,

On 11/5/19 2:21 AM, Marcin Cieślak wrote:
>> Bug reference:      16075
>> Logged by:          Liu Linhuai
>> Email address:      liulinhuai@yahoo.com
>> PostgreSQL version: 12.0
>> Operating system:   macOS
>> Description:
>>
>> Hi, I am using MacBook Pro and Google Chrome to visit
>> https://www.postgresql.org, the favicon on the browser's title look really
>> bad. I hope it's updated for a high-resolution version.

Can you please send this as an attachment instead of a diff?

Thanks!

Jonathan

Attachment

signature.asc

Re: [PATCH] 32x32 and 48x48 favicons

From

Marcin Cieslak

Date:

06 November 2019, 20:09:24

On Wed, 6 Nov 2019, Jonathan S. Katz wrote:

> Hi Marcin,
>
> On 11/5/19 2:21 AM, Marcin Cieślak wrote:
>>> Bug reference:      16075
>>> Logged by:          Liu Linhuai
>>> Email address:      liulinhuai@yahoo.com
>>> PostgreSQL version: 12.0
>>> Operating system:   macOS
>>> Description:
>>>
>>> Hi, I am using MacBook Pro and Google Chrome to visit
>>> https://www.postgresql.org, the favicon on the browser's title look really
>>> bad. I hope it's updated for a high-resolution version.
>
> Can you please send this as an attachment instead of a diff?

sure, attached.

if you prefer git

git clone https://repo.or.cz/pgweb/local.git
cd local
git checkout favicon_32_48.

Marcin

Attachment

Re: [PATCH] 32x32 and 48x48 favicons

From

Magnus Hagander

Date:

08 November 2019, 15:20:35

On Wed, Nov 6, 2019 at 6:09 PM Marcin Cieslak <saper@saper.info> wrote:

On Wed, 6 Nov 2019, Jonathan S. Katz wrote:

> Hi Marcin,
>
> On 11/5/19 2:21 AM, Marcin Cieślak wrote:
>>> Bug reference: 16075
>>> Logged by: Liu Linhuai
>>> Email address: liulinhuai@yahoo.com
>>> PostgreSQL version: 12.0
>>> Operating system: macOS
>>> Description:
>>>
>>> Hi, I am using MacBook Pro and Google Chrome to visit
>>> https://www.postgresql.org, the favicon on the browser's title look really
>>> bad. I hope it's updated for a high-resolution version.
>
> Can you please send this as an attachment instead of a diff?

sure, attached.

if you prefer git

git clone https://repo.or.cz/pgweb/local.git
cd local
git checkout favicon_32_48.

Thanks.

Applied and pushed, will take a while before it updates in all the caches.

//Magnus

Re: [PATCH] 32x32 and 48x48 favicons

From

Peter Geoghegan

Date:

13 November 2019, 01:20:39

On Fri, Nov 8, 2019 at 4:20 AM Magnus Hagander <magnus@hagander.net> wrote:
> Applied and pushed, will take a while before it updates in all the caches.

I think that the new favicon looks weird when actually seen in the
browser. Not sure if that’s due to the fact that the anti-aliasing
needs to work differently for the larger variant (i.e. needs to scale
down because it’ll appear on a “retina” display), or if the logo is
inherently a bad target to use directly as a favicon due to the level
of detail. I think that it's probably the former, though, since there
are examples of this working better with logos that are of similar
complexity to our own.

The favicon has certain artifacts…the pixels don’t get smushed
together enough. I am not an expert, but I think that this could be
improved on.

--
Peter Geoghegan