Thread: Do we have a CF manager for November?

It's time to start the next commitfest.  I seem to recall somebody
saying back in September that they'd run the next one, but I forget
who.  Anyway, we need a volunteer to be chief nagger.

            regards, tom lane

On Mon, Nov 04, 2019 at 10:54:52AM -0500, Tom Lane wrote:
> It's time to start the next commitfest.  I seem to recall somebody
> saying back in September that they'd run the next one, but I forget
> who.  Anyway, we need a volunteer to be chief nagger.

That may have been me.  I can take this one if there is nobody else
around.

Note: I have switched the app as in progress a couple of days ago,
after AoE was on the 1st of November of course.
--
Michael

On Tue, Nov 05, 2019 at 08:50:54PM +0500, Ibrar Ahmed wrote:
> On Tue, Nov 5, 2019 at 7:18 AM Michael Paquier <michael@paquier.xyz> wrote:
>> That may have been me.  I can take this one if there is nobody else
>> around.

Okay, so it is.  I have begun browsing the patch history, and we have
a loooot of work ahead.

> I am ready to help you with this.

Any help is welcome, thanks.
--
Michael

On Tue, Nov 05, 2019 at 11:18:00AM +0900, Michael Paquier wrote:
> That may have been me.  I can take this one if there is nobody else
> around.
>
> Note: I have switched the app as in progress a couple of days ago,
> after AoE was on the 1st of November of course.

So, we are close to the end of this commit fest, and I have done a
first pass on something like one third of the entries, mainly updating
incorrect patch status, bumping them into next CF or closing stale
items waiting on author.  As things stand, the progress is not that
good taking the total number of patches:
Needs review: 109.
Ready for Committer: 7.
Committed: 36.
Moved to next CF: 40.
Withdrawn: 4. Rejected: 6.
Returned with Feedback: 19
Total: 221.

So we still have a lot of patches in need of review, and most of them
will likely get bumped to the next CF.  The not-so-good news is that
numbers tend to be comparable with the last last CF.  An actual bad
news is that, based on what I have looked at until now, I have noticed
that a certain number of patches had an incorrect status for *weeks*
so it is actually necessary to go through each patch to make sure that
things are in a correct state in the CF app, which increases quite a
bit the classification work burden.

When looking at a patch, I usually try to use the following rules for
classification in a current CF:
- If patch is in "Needs Review" state, bump it to the next CF.
- If patch is in "Waiting on Author", with a state not updated for at
least two weeks, mark it as returned with feedback.
- If patch is in "Waiting on Author", with a state updated recently
(aka within two weeks), bump it to next CF with the same state.  This
requires more manual steps than the rest as the CF app does not allow
moving a patch to next CF waiting on author, but that's not right
either to bump out a patch without giving time to the author to answer
back.  Using half of the CF period looks rather right regarding that.

If you are registered as a patch author, reviewer or even committer,
it would be nice to look at each item you are involved in, and make
then sure that the patch you are looking at is in a correct state to
prevent any errors.  If you can move it to next CF or mark it as RwF
by yourself, this also saves cycles to the CFMs.  (Thanks Ibrar I
have noticed your activity!).

Thanks,
--
Michael

On Thu, Nov 28, 2019 at 04:02:55PM +0900, Michael Paquier wrote:
> So, we are close to the end of this commit fest, and I have done a
> first pass on something like one third of the entries, mainly updating
> incorrect patch status, bumping them into next CF or closing stale
> items waiting on author.

I have worked more on the CF.  And here are the final results:
Committed: 36.
Moved to next CF: 146.
Withdrawn: 4.
Rejected: 6.
Returned with Feedback: 29.
Total: 221.

The results are very comparable with the last CF, where 39 were marked
as committed and 28 as returned with feedback.  I know that we are
still a couple of hours before officially being in December AoE
(exactly 9), so I am a bit ahead.  My apologies about that.

I have been able to go through each patch, and pinged each author
where needed.  By the way, the cfbot has been extremely helpful in
this exercise:
http://commitfest.cputube.org/

Thanks,
--
Michael

Michael Paquier <michael@paquier.xyz> writes:
> I have worked more on the CF.  And here are the final results:
> Committed: 36.
> Moved to next CF: 146.
> Withdrawn: 4.
> Rejected: 6.
> Returned with Feedback: 29.
> Total: 221. 

As always, many thanks for doing this tedious work!

            regards, tom lane