Thread: Do not use C++ style comments (// comments). Strict ANSI C compilers do not accept them.
Do not use C++ style comments (// comments). Strict ANSI C compilers do not accept them.
From
PG Doc comments form
Date:
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/11/source-format.html Description: This sentence in the style guide feels outdated. // style comments have been in the ANSI C standard for almost 20 years now (C99 was accepted as ANSI standard in may 2000). I suggest rewording this to "Do not use C99 style comments (// comments). Strict C89 compilers do not accept them." or come up with some other reason for /**/ style being preferred to // style since I'm not entierly convinced postgres compiles on C89 anyways.
Re: Do not use C++ style comments (// comments). Strict ANSI Ccompilers do not accept them.
From
Peter Eisentraut
Date:
On 2019-09-23 16:39, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/11/source-format.html > Description: > > This sentence in the style guide feels outdated. // style comments have been > in the ANSI C standard for almost 20 years now (C99 was accepted as ANSI > standard in may 2000). I suggest rewording this to "Do not use C99 style > comments (// comments). Strict C89 compilers do not accept them." or come up > with some other reason for /**/ style being preferred to // style since I'm > not entierly convinced postgres compiles on C89 anyways. PostgreSQL 12 requires C99, so those guidelines should probably be rephrased from "because old compilers don't accept it" to "because we like it that way". -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Re: Do not use C++ style comments (// comments). Strict ANSI C compilers do not accept them.
From
Tom Lane
Date:
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> PostgreSQL 12 requires C99, so those guidelines should probably be
> rephrased from "because old compilers don't accept it" to "because we
> like it that way".
Yeah, or more formally "to encourage consistent coding style".
regards, tom lane
Re: Do not use C++ style comments (// comments). Strict ANSI Ccompilers do not accept them.
From
Peter Eisentraut
Date:
On 2019-09-25 00:13, Tom Lane wrote: > Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes: >> PostgreSQL 12 requires C99, so those guidelines should probably be >> rephrased from "because old compilers don't accept it" to "because we >> like it that way". > > Yeah, or more formally "to encourage consistent coding style". fixed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services