Thread: [pgAdmin][RM4631] PgAdmin IV browser locks up when trying to undo an edit

[pgAdmin][RM4631] PgAdmin IV browser locks up when trying to undo an edit

From
Aditya Toshniwal
Date:
Hi Hackers,

Attached is the patch to:
1) Optimise code folding code for better performance.
2) Moved all editor related preferences like Font size, Tab size, Brace matching, etc. 
from options to a new category "Editor" .
3) Added two new preferences - Plain editor mode (text/plain), Disable code folding.
4) Codemirror has its own limitations and lags for long text line. Using plain editor mode will help improve the speed as it does not have the overhead of syntax highlighting and code folding. Optionally, one can disable code folding in normal SQL mode.

Kindly review.
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Attachment

Re: [pgAdmin][RM4631] PgAdmin IV browser locks up when trying to undoan edit

From
Dave Page
Date:
Hi

On Mon, Sep 2, 2019 at 11:05 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to:
1) Optimise code folding code for better performance.
2) Moved all editor related preferences like Font size, Tab size, Brace matching, etc. 
from options to a new category "Editor" .
3) Added two new preferences - Plain editor mode (text/plain), Disable code folding.
4) Codemirror has its own limitations and lags for long text line. Using plain editor mode will help improve the speed as it does not have the overhead of syntax highlighting and code folding. Optionally, one can disable code folding in normal SQL mode.

Cool. Attached is an update which tweaks the strings on the Preferences panel. You'll find that useful when you add the missing screenshots and doc updates :-)

Thanks!
 
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment

Re: [pgAdmin][RM4631] PgAdmin IV browser locks up when trying to undoan edit

From
Aditya Toshniwal
Date:


On Mon, Sep 2, 2019 at 6:28 PM Dave Page <dpage@pgadmin.org> wrote:
Hi

On Mon, Sep 2, 2019 at 11:05 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to:
1) Optimise code folding code for better performance.
2) Moved all editor related preferences like Font size, Tab size, Brace matching, etc. 
from options to a new category "Editor" .
3) Added two new preferences - Plain editor mode (text/plain), Disable code folding.
4) Codemirror has its own limitations and lags for long text line. Using plain editor mode will help improve the speed as it does not have the overhead of syntax highlighting and code folding. Optionally, one can disable code folding in normal SQL mode.

Cool. Attached is an update which tweaks the strings on the Preferences panel. You'll find that useful when you add the missing screenshots and doc updates :-)
Thanks. Will send the updated patch. :) 

Thanks!
 
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

Re: [pgAdmin][RM4631] PgAdmin IV browser locks up when trying to undoan edit

From
Aditya Toshniwal
Date:
Hi Hackers,

Attached is the updated patch to include documentation updates.

On Tue, Sep 3, 2019 at 10:26 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:


On Mon, Sep 2, 2019 at 6:28 PM Dave Page <dpage@pgadmin.org> wrote:
Hi

On Mon, Sep 2, 2019 at 11:05 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to:
1) Optimise code folding code for better performance.
2) Moved all editor related preferences like Font size, Tab size, Brace matching, etc. 
from options to a new category "Editor" .
3) Added two new preferences - Plain editor mode (text/plain), Disable code folding.
4) Codemirror has its own limitations and lags for long text line. Using plain editor mode will help improve the speed as it does not have the overhead of syntax highlighting and code folding. Optionally, one can disable code folding in normal SQL mode.

Cool. Attached is an update which tweaks the strings on the Preferences panel. You'll find that useful when you add the missing screenshots and doc updates :-)
Thanks. Will send the updated patch. :) 

Thanks!
 
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Attachment

Re: [pgAdmin][RM4631] PgAdmin IV browser locks up when trying to undoan edit

From
Dave Page
Date:
Thanks, committed!

On Tue, Sep 3, 2019 at 7:01 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the updated patch to include documentation updates.

On Tue, Sep 3, 2019 at 10:26 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:


On Mon, Sep 2, 2019 at 6:28 PM Dave Page <dpage@pgadmin.org> wrote:
Hi

On Mon, Sep 2, 2019 at 11:05 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to:
1) Optimise code folding code for better performance.
2) Moved all editor related preferences like Font size, Tab size, Brace matching, etc. 
from options to a new category "Editor" .
3) Added two new preferences - Plain editor mode (text/plain), Disable code folding.
4) Codemirror has its own limitations and lags for long text line. Using plain editor mode will help improve the speed as it does not have the overhead of syntax highlighting and code folding. Optionally, one can disable code folding in normal SQL mode.

Cool. Attached is an update which tweaks the strings on the Preferences panel. You'll find that useful when you add the missing screenshots and doc updates :-)
Thanks. Will send the updated patch. :) 

Thanks!
 
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company