Thread: pgsql: Don't read fields of a misaligned ExpandedObjectHeader orAnyArr

Don't read fields of a misaligned ExpandedObjectHeader or AnyArrayType.

UBSan complains about this.  Instead, cast to a suitable type requiring
only 4-byte alignment.  DatumGetAnyArrayP() already assumes one can cast
between AnyArrayType and ArrayType, so this doesn't introduce a new
assumption.  Back-patch to 9.5, where AnyArrayType was introduced.

Reviewed by Tom Lane.

Discussion: https://postgr.es/m/20190629210334.GA1244217@rfd.leadboat.com

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/cd9d48969d944c3558a77745db389e8b68b46c4b

Modified Files
--------------
src/backend/utils/adt/arrayfuncs.c |  2 +-
src/include/utils/array.h          | 19 +++++++++++++------
src/include/utils/arrayaccess.h    |  4 ++--
src/include/utils/expandeddatum.h  |  2 +-
4 files changed, 17 insertions(+), 10 deletions(-)