Thread: pgsql: tableam: Add helper for indexes to check if a correspondingtabl
tableam: Add helper for indexes to check if a corresponding table tuples exist. This is, likely exclusively, useful to verify that conflicts detected in a unique index are with live tuples, rather than dead ones. Author: Andres Freund Discussion: https://postgr.es/m/20180703070645.wchpu5muyto5n647@alap3.anarazel.de Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/71bdc99d0d7c3b2d73fa04fb2ff80870ce1305f7 Modified Files -------------- src/backend/access/nbtree/nbtinsert.c | 17 ++++++++++------- src/backend/access/nbtree/nbtsort.c | 2 +- src/backend/access/table/tableam.c | 34 ++++++++++++++++++++++++++++++++++ src/include/access/tableam.h | 25 +++++++++++++++++++------ 4 files changed, 64 insertions(+), 14 deletions(-)
Re: pgsql: tableam: Add helper for indexes to check if acorresponding tabl
From
Peter Geoghegan
Date:
On Mon, Mar 25, 2019 at 5:34 PM Andres Freund <andres@anarazel.de> wrote: > tableam: Add helper for indexes to check if a corresponding table tuples exist. > > This is, likely exclusively, useful to verify that conflicts detected > in a unique index are with live tuples, rather than dead ones. Any reason why you didn't remove the heap_hot_search() wrapper function entirely? -- Peter Geoghegan
Hi, On 2019-03-25 17:47:17 -0700, Peter Geoghegan wrote: > On Mon, Mar 25, 2019 at 5:34 PM Andres Freund <andres@anarazel.de> wrote: > > tableam: Add helper for indexes to check if a corresponding table tuples exist. > > > > This is, likely exclusively, useful to verify that conflicts detected > > in a unique index are with live tuples, rather than dead ones. > > Any reason why you didn't remove the heap_hot_search() wrapper > function entirely? Hm. Fair question. I guess if there's any potential external users of it, they'd likely need to make v12 adjustments anyway? Greetings, Andres Freund
Re: pgsql: tableam: Add helper for indexes to check if acorresponding tabl
From
Peter Geoghegan
Date:
On Mon, Mar 25, 2019 at 6:00 PM Andres Freund <andres@anarazel.de> wrote: > Hm. Fair question. I guess if there's any potential external users of > it, they'd likely need to make v12 adjustments anyway? I'm not sure that they'd need to make adjustments. I think it's unlikely that there are any external users, though. -- Peter Geoghegan
Hi, On 2019-03-25 18:02:59 -0700, Peter Geoghegan wrote: > On Mon, Mar 25, 2019 at 6:00 PM Andres Freund <andres@anarazel.de> wrote: > > Hm. Fair question. I guess if there's any potential external users of > > it, they'd likely need to make v12 adjustments anyway? > > I'm not sure that they'd need to make adjustments. Yea, the probably do: https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=c2fe139c201c48f1133e9fbea2dd99b8efe2fadd#patch13 etc > I think it's unlikely that there are any external users, though. Yea, agreed. I'll remove it. - Andres