Thread: pgsql: pgbench: Remove \cset
pgbench: Remove \cset Partial revert of commit 6260cc550b0e, "pgbench: add \cset and \gset commands". While \gset is widely considered a useful and necessary tool for user- defined benchmarks, \cset does not have as much value, and its implementation was considered "not to be up to project standards" (though I, Álvaro, can't quite understand exactly how). Therefore, remove \cset. Author: Fabien Coelho Discussion: https://postgr.es/m/alpine.DEB.2.21.1903230716030.18811@lancre Discussion: https://postgr.es/m/201901101900.mv7zduch6sad@alvherre.pgsql Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/25ee70511ec2ccbef0ad3fe64875a4d552cdcd50 Modified Files -------------- doc/src/sgml/ref/pgbench.sgml | 55 +-------- src/bin/pgbench/pgbench.c | 165 ++++++--------------------- src/bin/pgbench/t/001_pgbench_with_server.pl | 47 +++----- src/fe_utils/psqlscan.l | 24 +--- src/include/fe_utils/psqlscan.h | 2 - src/include/fe_utils/psqlscan_int.h | 1 - 6 files changed, 56 insertions(+), 238 deletions(-)