Postgres Pro
Downloads
Home   >   mailing lists

Thread: [patch] use macro in setup script

[patch] use macro in setup script

From
"Wang, Shenhao"
Date:

Hi, everyone,

 

 

I found that in script postgresql-11-setup,  there are some codes

 

# Log file for pg_upgrade

PGUPLOG=/var/lib/pgsql/$PGMAJORVERSION/pgupgrade.log

# Log file for initdb

PGLOG=/var/lib/pgsql/11/initdb.log

 

Maybe using macro $PGMAJORVERSION is better instead of using 11 directly.

And I found that in postgresql-11-setup, this problem has been modified by this commit.

 

So, patch is attached

 

 

Regards;

Shenhao, Wang

 

-----------------------

Shenhao, Wang

DX3

Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST)

EMail:wangsh.fnst@cn.fujitsu.com

 

Attachment

Re: [patch] use macro in setup script

From
Devrim Gündüz
Date:
Hi ,

On Mon, 2019-03-04 at 10:53 +0000, Wang, Shenhao wrote:
> I found that in script postgresql-11-setup,  there are some codes
>
> # Log file for pg_upgrade
> PGUPLOG=/var/lib/pgsql/$PGMAJORVERSION/pgupgrade.log
> # Log file for initdb
> PGLOG=/var/lib/pgsql/11/initdb.log
>
> Maybe using macro $PGMAJORVERSION is better instead of using 11 directly.

Thanks for the patch. Applied. We'll release it along with next minor release.

Regards,
--
Devrim Gündüz
Open Source Solution Architect, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR
Attachment