Thread: [RM#3998] Custom encode forward slashes in the grid title

Hello,

PFA patch for the issue RM#3998. If the URL contains the forward slash value in the query tool title and if pgAdmin4 is behind Apache server then it fails to open to query tool and the user gets an error 404 because by default Apache does not allow encoded slashes in the URL and return 404.

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Mar 1, 2019 at 3:44 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi Murtuza,

Will this work if server name contains - !PG! ?

No, it won't and it's a custom signature we can finalize it whatever team thinks will work if the functionality is working properly.

 

On Fri, Mar 1, 2019 at 12:18 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hello,

PFA patch for the issue RM#3998. If the URL contains the forward slash value in the query tool title and if pgAdmin4 is behind Apache server then it fails to open to query tool and the user gets an error 404 because by default Apache does not allow encoded slashes in the URL and return 404.

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--

Thanks and Regards,

Aditya Toshniwal

Software Engineer | EnterpriseDB Software Solutions | Pune

"Don't Complain about Heat, Plant a tree"

Hi Murtuza,

I would suggest adding a new url param like "?fslash=12,15", which says where to put the forward slashes.

So if server name is "PostgreSQL/11" - connecting to postgres database with postgres username:

Old URL: http://localhost:5005/datagrid/panel/3400871/true/postgres%2Fpostgres%40PostgreSQL%2F11?query_url=&server_type=pg

New URL: http://localhost:5005/datagrid/panel/3400871/true/postgrespostgres%40PostgreSQL11?query_url=&server_type=pg&fslash=8,27

Value extracted: postgrespostgres@PostgreSQL11

Using fslash param, put the forward slashes in the mentioned positions: postgres/postgres@PostgreSQL/11

On Fri, Mar 1, 2019 at 4:07 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

On Fri, Mar 1, 2019 at 3:44 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi Murtuza,

Will this work if server name contains - !PG! ?

No, it won't and it's a custom signature we can finalize it whatever team thinks will work if the functionality is working properly.

 

On Fri, Mar 1, 2019 at 12:18 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hello,

PFA patch for the issue RM#3998. If the URL contains the forward slash value in the query tool title and if pgAdmin4 is behind Apache server then it fails to open to query tool and the user gets an error 404 because by default Apache does not allow encoded slashes in the URL and return 404.

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--

Thanks and Regards,

Aditya Toshniwal

Software Engineer | EnterpriseDB Software Solutions | Pune

"Don't Complain about Heat, Plant a tree"

--

Thanks and Regards,

Aditya Toshniwal

Software Engineer | EnterpriseDB Software Solutions | Pune

"Don't Complain about Heat, Plant a tree"

Hello Aditya,

Yes, that is a better approach, PFA updated patch.

Thanks,

Murtuza

On Fri, Mar 1, 2019 at 4:35 PM Dave Page <dpage@pgadmin.org> wrote:

That's a good idea. Seems much more robust.

On Fri, Mar 1, 2019 at 11:02 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi Murtuza,

I would suggest adding a new url param like "?fslash=12,15", which says where to put the forward slashes.

So if server name is "PostgreSQL/11" - connecting to postgres database with postgres username:

Old URL: http://localhost:5005/datagrid/panel/3400871/true/postgres%2Fpostgres%40PostgreSQL%2F11?query_url=&server_type=pg

New URL: http://localhost:5005/datagrid/panel/3400871/true/postgrespostgres%40PostgreSQL11?query_url=&server_type=pg&fslash=8,27

Value extracted: postgrespostgres@PostgreSQL11

Using fslash param, put the forward slashes in the mentioned positions: postgres/postgres@PostgreSQL/11

 

On Fri, Mar 1, 2019 at 4:07 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

On Fri, Mar 1, 2019 at 3:44 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi Murtuza,

Will this work if server name contains - !PG! ?

No, it won't and it's a custom signature we can finalize it whatever team thinks will work if the functionality is working properly.

 

On Fri, Mar 1, 2019 at 12:18 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hello,

PFA patch for the issue RM#3998. If the URL contains the forward slash value in the query tool title and if pgAdmin4 is behind Apache server then it fails to open to query tool and the user gets an error 404 because by default Apache does not allow encoded slashes in the URL and return 404.

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--

Thanks and Regards,

Aditya Toshniwal

Software Engineer | EnterpriseDB Software Solutions | Pune

"Don't Complain about Heat, Plant a tree"

--

Thanks and Regards,

Aditya Toshniwal

Software Engineer | EnterpriseDB Software Solutions | Pune

"Don't Complain about Heat, Plant a tree"

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company