Thread: BRIN summarize autovac_report_workitem passes datname as relname

src/backend/postmaster/autovacuum.c declares:

|static void
|autovac_report_workitem(AutoVacuumWorkItem *workitem,
|                        const char *nspname, const char *relname)

But calls it like:

|        cur_relname = get_rel_name(workitem->avw_relation);
|        cur_nspname = get_namespace_name(get_rel_namespace(workitem->avw_relation));
|        cur_datname = get_database_name(MyDatabaseId);
|        if (!cur_relname || !cur_nspname || !cur_datname)
|                goto deleted2;
|
|        autovac_report_workitem(workitem, cur_nspname, cur_datname);

So I see stuff like:

|check_pg - txn_time POSTGRES_TXN_TIME OK: DB main longest txn: 164s PID:10697 database:main username:
query:autovacuum:BRIN summarize public.main 1028223
 

I guess it should be database.namespace.relname ?

Em qua, 20 de fev de 2019 às 15:56, Justin Pryzby
<pryzby@telsasoft.com> escreveu:
>
> I guess it should be database.namespace.relname ?
>
Yup. It is an oversight in 7526e10224f0792201e99631567bbe44492bbde4.


--
   Euler Taveira                                   Timbira -
http://www.timbira.com.br/
   PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento

On 2019-Feb-20, Euler Taveira wrote:

> Em qua, 20 de fev de 2019 às 15:56, Justin Pryzby
> <pryzby@telsasoft.com> escreveu:
> >
> > I guess it should be database.namespace.relname ?
> >
> Yup. It is an oversight in 7526e10224f0792201e99631567bbe44492bbde4.

Oops.  Pushed fix.  Thanks for reporting.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services