Thread: [pgAdmin4][Patch] - RM 3959 - Properties and Dependents tabsrendering is slow with 1000+ records

Hi,

Please find the attached patch to fix the RM #3959 - Properties and Dependents tabs rendering is slow with 1000+ records.

Thanks,
Khushboo

Attachment
Hi

On Thu, Feb 14, 2019 at 5:44 AM Khushboo Vashi
<khushboo.vashi@enterprisedb.com> wrote:
>
> Hi,
>
> Please find the attached patch to fix the RM #3959 - Properties and Dependents tabs rendering is slow with 1000+
records.

There are a couple of PEP-8 issues (easy fixes), but more serious is
that the object icons are no longer being displayed on each row of the
tables.

Can you look into that please?

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Hi,

Please find the attached updated patch.

Thanks,
Khushboo

On Thu, Feb 14, 2019 at 3:05 PM Dave Page <dpage@pgadmin.org> wrote:
Hi

On Thu, Feb 14, 2019 at 5:44 AM Khushboo Vashi
<khushboo.vashi@enterprisedb.com> wrote:
>
> Hi,
>
> Please find the attached patch to fix the RM #3959 - Properties and Dependents tabs rendering is slow with 1000+ records.

There are a couple of PEP-8 issues (easy fixes),
Fixed 
but more serious is
that the object icons are no longer being displayed on each row of the
tables.

Fixed 
Can you look into that please?

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment
Hi

Thanks - patch applied.

I did spot another minor issue whilst testing - it's clearly not
caused by this patch though so I've logged it as #3994.

On Thu, Feb 14, 2019 at 9:55 AM Khushboo Vashi
<khushboo.vashi@enterprisedb.com> wrote:
>
> Hi,
>
> Please find the attached updated patch.
>
> Thanks,
> Khushboo
>
> On Thu, Feb 14, 2019 at 3:05 PM Dave Page <dpage@pgadmin.org> wrote:
>>
>> Hi
>>
>> On Thu, Feb 14, 2019 at 5:44 AM Khushboo Vashi
>> <khushboo.vashi@enterprisedb.com> wrote:
>> >
>> > Hi,
>> >
>> > Please find the attached patch to fix the RM #3959 - Properties and Dependents tabs rendering is slow with 1000+
records.
>>
>> There are a couple of PEP-8 issues (easy fixes),
>
> Fixed
>>
>> but more serious is
>> that the object icons are no longer being displayed on each row of the
>> tables.
>>
> Fixed
>>
>> Can you look into that please?
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company