Thread: "ALTER TRIGGER .. RENAME TO" broken with the "Remove WITH OIDS" commit.

"ALTER TRIGGER .. RENAME TO" broken with the "Remove WITH OIDS" commit.

From
Rushabh Lathia
Date:
Hi,

I found that ALTER TRIGGER .. RENAME TO is broken and it's
unable to rename the trigger.  Looking further seems renametrig()
function, copy the new trigger name into wrong tuple.  This is
broken with below commit:

commit 578b229718e8f15fa779e20f086c4b6bb3776106
Author: Andres Freund <andres@anarazel.de>
Date:   Tue Nov 20 15:36:57 2018 -0800

    Remove WITH OIDS support, change oid catalog column visibility.

PFA patch to fix the issue.  I also added the testcase for the
same into the regression.

regards,
Rushabh Lathia
Attachment

Re: "ALTER TRIGGER .. RENAME TO" broken with the "Remove WITH OIDS"commit.

From
Andres Freund
Date:
Hi,

On 2019-01-21 17:02:15 +0530, Rushabh Lathia wrote:
> Hi,
> 
> I found that ALTER TRIGGER .. RENAME TO is broken and it's
> unable to rename the trigger.  Looking further seems renametrig()
> function, copy the new trigger name into wrong tuple.  This is
> broken with below commit:
> 
> commit 578b229718e8f15fa779e20f086c4b6bb3776106
> Author: Andres Freund <andres@anarazel.de>
> Date:   Tue Nov 20 15:36:57 2018 -0800
> 
>     Remove WITH OIDS support, change oid catalog column visibility.
> 
> PFA patch to fix the issue.  I also added the testcase for the
> same into the regression.

Thanks for finding and the fix. Pushed!