Thread: [pgAdmin][RM3891]json/jsonb editing Save and Cancel buttons Reversed

[pgAdmin][RM3891]json/jsonb editing Save and Cancel buttons Reversed

From
Aditya Toshniwal
Date:
Hi Hackers,

Attached is the patch to fix correct the buttons for json/jsonb type column data editing.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
Attachment

Re: [pgAdmin][RM3891]json/jsonb editing Save and Cancel buttons Reversed

From
Dave Page
Date:
Could you rebase this please?

Thanks.

On Fri, Jan 18, 2019 at 10:58 AM Aditya Toshniwal
<aditya.toshniwal@enterprisedb.com> wrote:
>
> Hi Hackers,
>
> Attached is the patch to fix correct the buttons for json/jsonb type column data editing.
>
> Kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Re: [pgAdmin][RM3891]json/jsonb editing Save and Cancel buttons Reversed

From
Aditya Toshniwal
Date:
Hi Dave,

This patch is already committed and resolved. https://redmine.postgresql.org/issues/3891

On Thu, Jan 24, 2019 at 7:34 PM Dave Page <dpage@pgadmin.org> wrote:
Could you rebase this please?

Thanks.

On Fri, Jan 18, 2019 at 10:58 AM Aditya Toshniwal
<aditya.toshniwal@enterprisedb.com> wrote:
>
> Hi Hackers,
>
> Attached is the patch to fix correct the buttons for json/jsonb type column data editing.
>
> Kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"

Re: [pgAdmin][RM3891]json/jsonb editing Save and Cancel buttons Reversed

From
Dave Page
Date:
On Thu, Jan 24, 2019 at 2:09 PM Aditya Toshniwal
<aditya.toshniwal@enterprisedb.com> wrote:
>
> Hi Dave,
>
> This patch is already committed and resolved. https://redmine.postgresql.org/issues/3891

Oh, OK - I don't have a message in-thread saying that :-(

> On Thu, Jan 24, 2019 at 7:34 PM Dave Page <dpage@pgadmin.org> wrote:
>>
>> Could you rebase this please?
>>
>> Thanks.
>>
>> On Fri, Jan 18, 2019 at 10:58 AM Aditya Toshniwal
>> <aditya.toshniwal@enterprisedb.com> wrote:
>> >
>> > Hi Hackers,
>> >
>> > Attached is the patch to fix correct the buttons for json/jsonb type column data editing.
>> >
>> > Kindly review.
>> >
>> > --
>> > Thanks and Regards,
>> > Aditya Toshniwal
>> > Software Engineer | EnterpriseDB Software Solutions | Pune
>> > "Don't Complain about Heat, Plant a tree"
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company