Thread: [pgAdmin4][RM3908] backgrid navigation fix for Select2Cell and PrivilegeCell

[pgAdmin4][RM3908] backgrid navigation fix for Select2Cell and PrivilegeCell

From
Harshal Dhumal
Date:
Hi,
Please find attached patch to fix backgrid navigation using keyboard
for Select2Cell and PrivilegeCell

-- 
Harshal Dhumal
Sr. Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment
Hi Khushboo 

Can you please review it.

On Thu, Jan 17, 2019 at 7:22 PM Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,
Please find attached patch to fix backgrid navigation using keyboard
for Select2Cell and PrivilegeCell

-- 
Harshal Dhumal
Sr. Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Akshay Joshi
Sr. Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

Re: [pgAdmin4][RM3908] backgrid navigation fix for Select2Cell and PrivilegeCell

From
Khushboo Vashi
Date:
Hi Harshal,

The Selec2Cell and PrivilegeCell are working properly but I think we should also consider below:

1. The Backgrid and sub-node should have accessibility including every button, cell and control.
2. The Backgrid table header is accessible through keyboard but it should be highlighted when it gets focus.

@Akshay, we can commit this patch but we should create the separate RM for above fixes.

Thanks,
Khushboo


On Mon, Jan 21, 2019 at 4:40 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Khushboo 

Can you please review it.

On Thu, Jan 17, 2019 at 7:22 PM Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,
Please find attached patch to fix backgrid navigation using keyboard
for Select2Cell and PrivilegeCell

-- 
Harshal Dhumal
Sr. Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Akshay Joshi
Sr. Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Thanks patch applied 

On Tue, Jan 22, 2019 at 3:02 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Harshal,

The Selec2Cell and PrivilegeCell are working properly but I think we should also consider below:

1. The Backgrid and sub-node should have accessibility including every button, cell and control.
2. The Backgrid table header is accessible through keyboard but it should be highlighted when it gets focus.

@Akshay, we can commit this patch but we should create the separate RM for above fixes.

     RM # 3919 has been created by Harshal.

Thanks,
Khushboo


On Mon, Jan 21, 2019 at 4:40 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Khushboo 

Can you please review it.

On Thu, Jan 17, 2019 at 7:22 PM Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,
Please find attached patch to fix backgrid navigation using keyboard
for Select2Cell and PrivilegeCell

-- 
Harshal Dhumal
Sr. Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Akshay Joshi
Sr. Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246


--
Akshay Joshi
Sr. Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246