Thread: [pgAdmin4][patch] pgadmin responsive not working as expected for desktop
[pgAdmin4][patch] pgadmin responsive not working as expected for desktop
From
Aditya Toshniwal
Date:
Hi Hackers,
Attached is the patch to fix controls alignment responsiveness to docker size change.
Kindly review.
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
Attachment
Hi Could you rebase this please? Thanks. On Thu, Jan 17, 2019 at 12:33 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote: > > Hi Hackers, > > Attached is the patch to fix controls alignment responsiveness to docker size change. > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Oh, and what RM is it related to? On Thu, Jan 24, 2019 at 2:01 PM Dave Page <dpage@pgadmin.org> wrote: > > Hi > > Could you rebase this please? > > Thanks. > > On Thu, Jan 17, 2019 at 12:33 PM Aditya Toshniwal > <aditya.toshniwal@enterprisedb.com> wrote: > > > > Hi Hackers, > > > > Attached is the patch to fix controls alignment responsiveness to docker size change. > > > > Kindly review. > > > > -- > > Thanks and Regards, > > Aditya Toshniwal > > Software Engineer | EnterpriseDB Software Solutions | Pune > > "Don't Complain about Heat, Plant a tree" > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: [pgAdmin4][patch] pgadmin responsive not working as expected for desktop
From
Aditya Toshniwal
Date:
Hi Dave,
This patch is applied and is a regression of new design changes. https://github.com/postgres/pgadmin4/commit/48660508ce52a34a94b41baceb3ff49bb134f22c
On Thu, Jan 24, 2019 at 7:32 PM Dave Page <dpage@pgadmin.org> wrote:
Oh, and what RM is it related to?
On Thu, Jan 24, 2019 at 2:01 PM Dave Page <dpage@pgadmin.org> wrote:
>
> Hi
>
> Could you rebase this please?
>
> Thanks.
>
> On Thu, Jan 17, 2019 at 12:33 PM Aditya Toshniwal
> <aditya.toshniwal@enterprisedb.com> wrote:
> >
> > Hi Hackers,
> >
> > Attached is the patch to fix controls alignment responsiveness to docker size change.
> >
> > Kindly review.
> >
> > --
> > Thanks and Regards,
> > Aditya Toshniwal
> > Software Engineer | EnterpriseDB Software Solutions | Pune
> > "Don't Complain about Heat, Plant a tree"
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
Hi On Thu, Jan 24, 2019 at 2:12 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote: > > Hi Dave, > > This patch is applied and is a regression of new design changes. https://github.com/postgres/pgadmin4/commit/48660508ce52a34a94b41baceb3ff49bb134f22c Oh. Not sure it worked very well. See the attached screenshot which shows the messed-up menu bar hiding tabs. > On Thu, Jan 24, 2019 at 7:32 PM Dave Page <dpage@pgadmin.org> wrote: >> >> Oh, and what RM is it related to? >> >> On Thu, Jan 24, 2019 at 2:01 PM Dave Page <dpage@pgadmin.org> wrote: >> > >> > Hi >> > >> > Could you rebase this please? >> > >> > Thanks. >> > >> > On Thu, Jan 17, 2019 at 12:33 PM Aditya Toshniwal >> > <aditya.toshniwal@enterprisedb.com> wrote: >> > > >> > > Hi Hackers, >> > > >> > > Attached is the patch to fix controls alignment responsiveness to docker size change. >> > > >> > > Kindly review. >> > > >> > > -- >> > > Thanks and Regards, >> > > Aditya Toshniwal >> > > Software Engineer | EnterpriseDB Software Solutions | Pune >> > > "Don't Complain about Heat, Plant a tree" >> > >> > >> > >> > -- >> > Dave Page >> > Blog: http://pgsnake.blogspot.com >> > Twitter: @pgsnake >> > >> > EnterpriseDB UK: http://www.enterprisedb.com >> > The Enterprise PostgreSQL Company >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company > > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Attachment
Re: [pgAdmin4][patch] pgadmin responsive not working as expected for desktop
From
Aditya Toshniwal
Date:
Oh it was not for mobile view screen. It was for the desktop view.
On Thu, Jan 24, 2019, 19:50 Dave Page <dpage@pgadmin.org wrote:
Hi
On Thu, Jan 24, 2019 at 2:12 PM Aditya Toshniwal
<aditya.toshniwal@enterprisedb.com> wrote:
>
> Hi Dave,
>
> This patch is applied and is a regression of new design changes. https://github.com/postgres/pgadmin4/commit/48660508ce52a34a94b41baceb3ff49bb134f22c
Oh. Not sure it worked very well. See the attached screenshot which
shows the messed-up menu bar hiding tabs.
> On Thu, Jan 24, 2019 at 7:32 PM Dave Page <dpage@pgadmin.org> wrote:
>>
>> Oh, and what RM is it related to?
>>
>> On Thu, Jan 24, 2019 at 2:01 PM Dave Page <dpage@pgadmin.org> wrote:
>> >
>> > Hi
>> >
>> > Could you rebase this please?
>> >
>> > Thanks.
>> >
>> > On Thu, Jan 17, 2019 at 12:33 PM Aditya Toshniwal
>> > <aditya.toshniwal@enterprisedb.com> wrote:
>> > >
>> > > Hi Hackers,
>> > >
>> > > Attached is the patch to fix controls alignment responsiveness to docker size change.
>> > >
>> > > Kindly review.
>> > >
>> > > --
>> > > Thanks and Regards,
>> > > Aditya Toshniwal
>> > > Software Engineer | EnterpriseDB Software Solutions | Pune
>> > > "Don't Complain about Heat, Plant a tree"
>> >
>> >
>> >
>> > --
>> > Dave Page
>> > Blog: http://pgsnake.blogspot.com
>> > Twitter: @pgsnake
>> >
>> > EnterpriseDB UK: http://www.enterprisedb.com
>> > The Enterprise PostgreSQL Company
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Oh, OK - well please log a ticket and fix that too then :-) On Thu, Jan 24, 2019 at 2:48 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote: > > Oh it was not for mobile view screen. It was for the desktop view. > > On Thu, Jan 24, 2019, 19:50 Dave Page <dpage@pgadmin.org wrote: >> >> Hi >> >> On Thu, Jan 24, 2019 at 2:12 PM Aditya Toshniwal >> <aditya.toshniwal@enterprisedb.com> wrote: >> > >> > Hi Dave, >> > >> > This patch is applied and is a regression of new design changes. https://github.com/postgres/pgadmin4/commit/48660508ce52a34a94b41baceb3ff49bb134f22c >> >> Oh. Not sure it worked very well. See the attached screenshot which >> shows the messed-up menu bar hiding tabs. >> >> > On Thu, Jan 24, 2019 at 7:32 PM Dave Page <dpage@pgadmin.org> wrote: >> >> >> >> Oh, and what RM is it related to? >> >> >> >> On Thu, Jan 24, 2019 at 2:01 PM Dave Page <dpage@pgadmin.org> wrote: >> >> > >> >> > Hi >> >> > >> >> > Could you rebase this please? >> >> > >> >> > Thanks. >> >> > >> >> > On Thu, Jan 17, 2019 at 12:33 PM Aditya Toshniwal >> >> > <aditya.toshniwal@enterprisedb.com> wrote: >> >> > > >> >> > > Hi Hackers, >> >> > > >> >> > > Attached is the patch to fix controls alignment responsiveness to docker size change. >> >> > > >> >> > > Kindly review. >> >> > > >> >> > > -- >> >> > > Thanks and Regards, >> >> > > Aditya Toshniwal >> >> > > Software Engineer | EnterpriseDB Software Solutions | Pune >> >> > > "Don't Complain about Heat, Plant a tree" >> >> > >> >> > >> >> > >> >> > -- >> >> > Dave Page >> >> > Blog: http://pgsnake.blogspot.com >> >> > Twitter: @pgsnake >> >> > >> >> > EnterpriseDB UK: http://www.enterprisedb.com >> >> > The Enterprise PostgreSQL Company >> >> >> >> >> >> >> >> -- >> >> Dave Page >> >> Blog: http://pgsnake.blogspot.com >> >> Twitter: @pgsnake >> >> >> >> EnterpriseDB UK: http://www.enterprisedb.com >> >> The Enterprise PostgreSQL Company >> > >> > >> > >> > -- >> > Thanks and Regards, >> > Aditya Toshniwal >> > Software Engineer | EnterpriseDB Software Solutions | Pune >> > "Don't Complain about Heat, Plant a tree" >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company