Thread: Some typos in documentation

Some typos in documentation

From
Alexander Lakhin
Date:
Hello,
While cross-checking the unique words in doc/ I found a few typos.

REL9_6_STABLE
transcations
(Also there are two 'transcation's in src/bin/psql/po/tr.po, probably
these are typos too.)

REL_10_STABLE+
PQencryptPasswodConn

pg_current_logfiles -- there is only the "pg_current_logfile" function.

NOCONNECT -- this option was replaced with "connect = false" by commit
b807f5982.

LockFileCreateWrite -- Should be spelled as LockFileCreateWRITE (as in
pgstat.c) or LockFileCreateWRITE in pg.stat.s should use CamelCase in
whole. I don't find any dependencies so I would prefer the latter.

REL_11_STABLE+
pg_execute_server_programs -- I could find only the
pg_execute_server_program role in pg_authid.dat.

All the corresponding patches are attached.

Best regards,
Alexander



Attachment

Re: Some typos in documentation

From
Michael Paquier
Date:
On Sun, Jan 13, 2019 at 12:17:07AM +0300, Alexander Lakhin wrote:
> While cross-checking the unique words in doc/ I found a few typos.

Those are good finds, thanks for the report!

> LockFileCreateWrite -- Should be spelled as LockFileCreateWRITE (as in
> pgstat.c) or LockFileCreateWRITE in pg.stat.s should use CamelCase in
> whole. I don't find any dependencies so I would prefer the latter.

For consistency with the rest I think that we should use
LockFileCreateWrite in pgstat.c as well as you do, though this could
be qualified as a behavior change.  That's also the grammar which is
documented since the beginning.  Any objections from others?

> All the corresponding patches are attached.

Cool, I'll see to apply them where needed.  I'll just wait to see if
anybody has comments about the pgstat.c portion.
--
Michael

Attachment

Re: Some typos in documentation

From
Michael Paquier
Date:
On Sun, Jan 13, 2019 at 09:34:36AM +0900, Michael Paquier wrote:
> Cool, I'll see to apply them where needed.  I'll just wait to see if
> anybody has comments about the pgstat.c portion.

And done.
--
Michael

Attachment