Postgres Pro
Downloads
Home   >   mailing lists

Thread: some minor comment fix in md.c

some minor comment fix in md.c

From
"Jamison, Kirk"
Date:

Hi,

 

Here are few minor fix in md.c comments

src/backend/storage/smgr/md.c

 

1. @L174 - removed the unnecessary word "is".

- […] Note that this is breaks mdnblocks() and related functionality [...]

+ […] Note that this breaks mdnblocks() and related functionality [...]

 

2. @L885 - grammar fix

- We used to pass O_CREAT here, but that's has the disadvantage that it might [...]

+ We used to pass O_CREAT here, but that has the disadvantage that it might [...]

 

Regards,

Kirk J.

Attachment

Re: some minor comment fix in md.c

From
Michael Paquier
Date:
On Wed, Jan 09, 2019 at 08:30:53AM +0000, Jamison, Kirk wrote:
> Here are few minor fix in md.c comments
> src/backend/storage/smgr/md.c
>
> 1. @L174 - removed the unnecessary word "is".
> - […] Note that this is breaks mdnblocks() and related functionality [...]
> + […] Note that this breaks mdnblocks() and related functionality [...]
>
> 2. @L885 - grammar fix
> - We used to pass O_CREAT here, but that's has the disadvantage that it might [...]
> + We used to pass O_CREAT here, but that has the disadvantage that it might [...]

Thanks, that looks good to me so pushed.
--
Michael
Attachment