Thread: Minor comment fix for pg_config_manual.h
Hi Attached is mainly to fix a comment in $subject which has a typo in the referenced initdb option ("--walsegsize", should be "--wal-segsize"), and while I'm there also adds a couple of "the" for readability. Regards Ian Barwick -- Ian Barwick http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
Attachment
On Mon, Dec 24, 2018 at 01:05:25PM +0900, Ian Barwick wrote: > Attached is mainly to fix a comment in $subject which has a typo in > the referenced initdb option ("--walsegsize", should be > "--wal-segsize"), and while I'm there also adds a couple of "the" > for readability. All that (the error as well as the extra "the" for clarity in this sentence) seems right to me. Any opinions from others? -- Michael
Attachment
Michael Paquier <michael@paquier.xyz> writes: > On Mon, Dec 24, 2018 at 01:05:25PM +0900, Ian Barwick wrote: >> Attached is mainly to fix a comment in $subject which has a typo in >> the referenced initdb option ("--walsegsize", should be >> "--wal-segsize"), and while I'm there also adds a couple of "the" >> for readability. > All that (the error as well as the extra "the" for clarity in this > sentence) seems right to me. Any opinions from others? The text still seems a bit awkward. Maybe "... to be used when initdb is run without the ..." regards, tom lane
On Tue, Dec 25, 2018 at 10:22:30AM -0500, Tom Lane wrote: > The text still seems a bit awkward. Maybe "... to be used when initdb > is run without the ..." like the attached perhaps? At the same time I am thinking about reformulating the second sentence as well.. -- Michael
Attachment
On Wed, Dec 26, 2018 at 09:36:57AM +0900, Michael Paquier wrote: > like the attached perhaps? At the same time I am thinking about > reformulating the second sentence as well.. > > /* > - * This is default value for wal_segment_size to be used at initdb when run > - * without --walsegsize option. Must be a valid segment size. > + * This is the default value for wal_segment_size to be used when initdb is run > + * without the --wal-segsize option. It must be a valid segment size. > */ > #define DEFAULT_XLOG_SEG_SIZE (16*1024*1024) So, any objections with this change? If somebody has a better wording, please feel free to chime in. -- Michael
Attachment
On 2018-Dec-28, Michael Paquier wrote: > On Wed, Dec 26, 2018 at 09:36:57AM +0900, Michael Paquier wrote: > > like the attached perhaps? At the same time I am thinking about > > reformulating the second sentence as well.. > > > > /* > > - * This is default value for wal_segment_size to be used at initdb when run > > - * without --walsegsize option. Must be a valid segment size. > > + * This is the default value for wal_segment_size to be used when initdb is run > > + * without the --wal-segsize option. It must be a valid segment size. > > */ > > #define DEFAULT_XLOG_SEG_SIZE (16*1024*1024) > > So, any objections with this change? If somebody has a better > wording, please feel free to chime in. Looks good to me. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On Fri, Dec 28, 2018 at 12:37:41AM -0300, Alvaro Herrera wrote: > Looks good to me. Thanks for the lookup. I have committed and back-patched to v11 for consistency. -- Michael
Attachment
On 12/29/18 8:27 AM, Michael Paquier wrote: > On Fri, Dec 28, 2018 at 12:37:41AM -0300, Alvaro Herrera wrote: >> Looks good to me. > > Thanks for the lookup. I have committed and back-patched to v11 for > consistency. Thanks! Regards Ian Barwick -- Ian Barwick http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services