Postgres Pro
Downloads
Home   >   mailing lists

Thread: [pgAdmin4][Patch]: RM #3464 pgAdmin 4 won't start on windows

[pgAdmin4][Patch]: RM #3464 pgAdmin 4 won't start on windows

From
Akshay Joshi
Date:
Hi Hackers, 

Recently we have added basic startup logs and because of that we came to know that pgAdmin4 is not able to open the log file if the file path contains Cyrillic alphabet or Special characters.
fopen fails to open the file, so I have used _wfopen for Windows operating system.  
 
Attached is the patch to fix that issue. Please review it.   

--
Akshay Joshi
Sr. Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Attachment

Re: [pgAdmin4][Patch]: RM #3464 pgAdmin 4 won't start on windows

From
Dave Page
Date:
Hi

On Tue, Sep 18, 2018 at 12:18 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Hackers, 

Recently we have added basic startup logs and because of that we came to know that pgAdmin4 is not able to open the log file if the file path contains Cyrillic alphabet or Special characters.
fopen fails to open the file, so I have used _wfopen for Windows operating system.  
 
Attached is the patch to fix that issue. Please review it.   

I assume this doesn't affect the address file or startup log? Only the Python log? 


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: RM #3464 pgAdmin 4 won't start on windows

From
Akshay Joshi
Date:


On Tue, Sep 18, 2018 at 4:52 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Tue, Sep 18, 2018 at 12:18 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Hackers, 

Recently we have added basic startup logs and because of that we came to know that pgAdmin4 is not able to open the log file if the file path contains Cyrillic alphabet or Special characters.
fopen fails to open the file, so I have used _wfopen for Windows operating system.  
 
Attached is the patch to fix that issue. Please review it.   

I assume this doesn't affect the address file or startup log? Only the Python log?

    Yes. we have used fopen when we redirect the stderr to the Python log file. 


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Akshay Joshi
Sr. Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

Re: [pgAdmin4][Patch]: RM #3464 pgAdmin 4 won't start on windows

From
Dave Page
Date:
Thanks - patch applied. Great work figuring this one out!

On Tue, Sep 18, 2018 at 12:18 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Hackers, 

Recently we have added basic startup logs and because of that we came to know that pgAdmin4 is not able to open the log file if the file path contains Cyrillic alphabet or Special characters.
fopen fails to open the file, so I have used _wfopen for Windows operating system.  
 
Attached is the patch to fix that issue. Please review it.   

--
Akshay Joshi
Sr. Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company