Thread: Update comment in errcodes.txt correctly

Update comment in errcodes.txt correctly

From
"Shinoda, Noriyoshi (PN Japan GCS Delivery)"
Date:
Hi, Hackers,

The attached small patch updates src/backend/utils/errcode.txt.
In the comment of this file, a list of file names generated from this file is written.
However, the file name of the 'errcodes.sgml' file is incorrect.
The attached patch fixes the incorrect path of errcodes.sgml file name.

Regards,
Noriyoshi Shinoda

Attachment

Re: Update comment in errcodes.txt correctly

From
Michael Paquier
Date:
On Thu, Aug 16, 2018 at 01:18:21AM +0000, Shinoda, Noriyoshi (PN Japan GCS Delivery) wrote:
> The attached small patch updates src/backend/utils/errcode.txt.
> In the comment of this file, a list of file names generated from this file is written.
> However, the file name of the 'errcodes.sgml' file is incorrect.
> The attached patch fixes the incorrect path of errcodes.sgml file name.

It seems to me that doc/src/sgml/errcodes-table.sgml is the one
generated.  errcodes.sgml includes just a reference to the table
produced.
--
Michael

Attachment

RE: Update comment in errcodes.txt correctly

From
"Shinoda, Noriyoshi (PN Japan GCS Delivery)"
Date:
Michael-san,
Thank you for your responsse.

> It seems to me that doc/src/sgml/errcodes-table.sgml is the one generated.  errcodes.sgml includes just a reference
tothe table produced. 
Oh, I think your opinion is correct.

I attached a modified version.

Regards,
Noriyoshi Shinoda

-----Original Message-----
From: Michael Paquier [mailto:michael@paquier.xyz]
Sent: Thursday, August 16, 2018 12:44 PM
To: Shinoda, Noriyoshi (PN Japan GCS Delivery) <noriyoshi.shinoda@hpe.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Update comment in errcodes.txt correctly

On Thu, Aug 16, 2018 at 01:18:21AM +0000, Shinoda, Noriyoshi (PN Japan GCS Delivery) wrote:
> The attached small patch updates src/backend/utils/errcode.txt.
> In the comment of this file, a list of file names generated from this file is written.
> However, the file name of the 'errcodes.sgml' file is incorrect.
> The attached patch fixes the incorrect path of errcodes.sgml file name.

It seems to me that doc/src/sgml/errcodes-table.sgml is the one generated.  errcodes.sgml includes just a reference to
thetable produced. 
--
Michael

Attachment

Re: Update comment in errcodes.txt correctly

From
Michael Paquier
Date:
On Thu, Aug 16, 2018 at 04:36:11AM +0000, Shinoda, Noriyoshi (PN Japan GCS Delivery) wrote:
> I attached a modified version.

Thanks, Shinoda-san.  Pushed.
--
Michael

Attachment