Postgres Pro
Downloads
Home   >   mailing lists

Thread: [pgAdmin4][RM#3319] Fix the cancel query button glitch in query tool

[pgAdmin4][RM#3319] Fix the cancel query button glitch in query tool

From
Murtuza Zabuawala
Date:
Hi,

PFA patch to fix the issue where cancel button remains enabled even after the query execution completes, I have moved the enable/disable logic for that button with rest of the buttons in 'disable_tool_buttons' method & removed tests which are not required as we are already testing 'disable_tool_buttons' method.

I had to fix it coz it was annoying me :)


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment

Re: [pgAdmin4][RM#3319] Fix the cancel query button glitch in query tool

From
Dave Page
Date:
Thanks, patch applied.

On Mon, Jul 2, 2018 at 5:58 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to fix the issue where cancel button remains enabled even after the query execution completes, I have moved the enable/disable logic for that button with rest of the buttons in 'disable_tool_buttons' method & removed tests which are not required as we are already testing 'disable_tool_buttons' method.

I had to fix it coz it was annoying me :)


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company