Thread: pgsql: Fix crash when ALTER TABLE recreates indexes on partitions

pgsql: Fix crash when ALTER TABLE recreates indexes on partitions

From
Alvaro Herrera
Date:
Fix crash when ALTER TABLE recreates indexes on partitions

The skip_build flag was not being passed correctly when recursing to
indexes on partitions, leading to attempts to rebuild indexes when they
were not yet ready to be rebuilt.

Reported-by: Rajkumar Raghuwanshi
Discussion: https://postgr.es/m/CAKcux6mxNCGsgATwf5CGMF8g4WSupCXicCVMeKUTuWbyxHOMsQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/41372071dfaab97a1a8dca83e32b88413460f477

Modified Files
--------------
src/backend/commands/indexcmds.c       | 2 +-
src/test/regress/expected/indexing.out | 8 ++++++++
src/test/regress/sql/indexing.sql      | 9 +++++++++
3 files changed, 18 insertions(+), 1 deletion(-)


Re: pgsql: Fix crash when ALTER TABLE recreates indexes on partitions

From
Tom Lane
Date:
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> Fix crash when ALTER TABLE recreates indexes on partitions

So ... buildfarm member skink has been reporting a valgrind failure
during initdb since this patch went in.  However, I'm unable to reproduce
such a failure here, and it's less than obvious how this particular patch
could have caused a problem, and skink's report is pretty useless because
it's providing only a numeric stack trace.  Thoughts?

            regards, tom lane